[issue34693] PEPping distutils/core.py

2018-09-15 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report and for the PR, John. Karthikeyan is correct. Many of the modules in the stdlib predate PEP 8. Also, making PEP 8-only changes would make "git blame" less useful and can cause regressions (IIRC it has happened at least once, but I don't

[issue34693] PEPping distutils/core.py

2018-09-15 Thread John Joyce
John Joyce added the comment: Oh, I see. I did not realize that tidying would not be accepted. That explains a lot. As it offended linters based on PEPs I chose that as the best match. It is pedantic, but many linting actions are not far from compiling... they are generally parsing to

[issue34693] PEPping distutils/core.py

2018-09-15 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks for the contribution. Is there any syntax error on using the file since you have classified it as compile error or the error messages are related to linters? On a general note style related contributions are not merged since they create

[issue34693] PEPping distutils/core.py

2018-09-15 Thread John Joyce
New submission from John Joyce : In distutils/core.py ... Line 227 is over-indented, inconsistent with the rest of the file. Line 226 is over-indented, inconsistent with the rest of the file. Line 114 is over-indented by 2 characters, inconsistent with the rest of the file. else: