[issue34722] Non-deterministic bytecode generation

Chih-Hsuan Yen added the comment: issue37596 merged a fix to enable deterministic frozensets. I think this issue can be closed? Regarding my last comment msg347820 - it seems similar to one of https://bugs.python.org/issue34033 or https://bugs.python.org/issue34093. I followed those tickets

[issue34722] Non-deterministic bytecode generation

Change by Jeffery To : -- nosy: +jefferyto ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue34722] Non-deterministic bytecode generation

Chih-Hsuan Yen added the comment: I encounter another case that leads to non-deterministic bytecode. For example, with commit e6b46aafad3427463d6264a68824df4797e682f1 + PR 9472, I got: $ cat foobar.py _m = None $ PYTHONHASHSEED=0 ./python -m compileall --invalidation-mode=unchecked-hash foob

[issue34722] Non-deterministic bytecode generation

Change by Karthikeyan Singaravelan : -- nosy: +pablogsal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue34722] Non-deterministic bytecode generation

Change by Serhiy Storchaka : -- versions: +Python 3.9 -Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue34722] Non-deterministic bytecode generation

Change by Chih-Hsuan Yen : -- nosy: +yan12125 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue34722] Non-deterministic bytecode generation

Raymond Hettinger added the comment: Bumping up the priority a bit on this one. It would be nice to get it in for 3.8. -- priority: normal -> high versions: +Python 3.8 -Python 3.7 ___ Python tracker _

[issue34722] Non-deterministic bytecode generation

Change by Peter Ebden : -- keywords: +patch pull_requests: +8885 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue34722] Non-deterministic bytecode generation

Benjamin Peterson added the comment: Possibly we should just sort the individual marsahalled entries of the frozenset. -- ___ Python tracker ___ _

[issue34722] Non-deterministic bytecode generation

Peter Ebden added the comment: Thanks for the pointer, I'll have a bit more of a dig into it (although Serhiy makes a good point too...). -- ___ Python tracker ___ __

[issue34722] Non-deterministic bytecode generation

Change by Eric Snow : -- nosy: +benjamin.peterson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue34722] Non-deterministic bytecode generation

Serhiy Storchaka added the comment: Not all types are orderable. >>> sorted({'', None}) Traceback (most recent call last): File "", line 1, in TypeError: '<' not supported between instances of 'NoneType' and 'str' -- nosy: +serhiy.storchaka ___

[issue34722] Non-deterministic bytecode generation

Raymond Hettinger added the comment: Have a look at line 512 in Python/marshal.c which calls PyObject_GetIter(). We would need to add PySequence_List() and PyList_Sort(). This will slow down marshaling but would make the bytecode deterministic. -- nosy: +rhettinger ___

[issue34722] Non-deterministic bytecode generation

New submission from Peter Ebden : We've found that the following code produces non-deterministic bytecode, even post PEP-552: def test(x): if x in {'ONE', 'TWO', 'THREE'}: pass It's not too hard to test it: $ python3.7 -m compileall --invalidation-mode=unchecked-hash test.py Compi