[issue34897] distutils test errors when CXX is not set

Jan Pieczkowski added the comment: This issue also still affects Python versions 3.6.15 and 3.7.12 IMHO it would make sense to backport this patch to the 3.6 and 3.7 branches, especially as it only affects one line of code and doesn't seem to affect anything else, but solves the same issue

[issue34897] distutils test errors when CXX is not set

Change by Nick Coghlan : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue34897] distutils test errors when CXX is not set

Nick Coghlan added the comment: New changeset 259c159fc1faab0dd631d20374842dc0d6a9f145 by Nick Coghlan (Michael Felt) in branch 'master': bpo-34897: avoid distutils test error when CXX is not set (GH-9706) https://github.com/python/cpython/commit/259c159fc1faab0dd631d20374842dc0d6a9f145

[issue34897] distutils test errors when CXX is not set

Change by Michael Felt : -- pull_requests: +10576 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34897] distutils test errors when CXX is not set

Change by Michael Felt : -- pull_requests: +10576, 10577 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34897] distutils test errors when CXX is not set

Tal Einat added the comment: Michael, please read more about comparisons[1] and the None object[2]. [1] https://docs.python.org/3/library/stdtypes.html#comparisons [2] https://docs.python.org/3/library/stdtypes.html#the-null-object -- ___ Python

[issue34897] distutils test errors when CXX is not set

Michael Felt added the comment: Thx. So, while "" is not None (i.e., "" is not False), it does test as a Boolean expression as 'False' so the test for None or "" is the same as testing for "" (but not the same as testing for None). I accept your logic - and shall make the change in the

[issue34897] distutils test errors when CXX is not set

Change by Tal Einat : -- Removed message: https://bugs.python.org/msg329154 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue34897] distutils test errors when CXX is not set

Tal Einat added the comment: `not cmd` will but true if cmd is None, so it is completely equivalent to `cmd is None or not cmd`. This is a purely stylistic change which doesn't alter the logic. To get a clear understanding of what's going on, I recommend reading the short "Truth Value

[issue34897] distutils test errors when CXX is not set

Tal Einat added the comment: `not cmd` will be true if cmd is None, so it is completely equivalent to `cmd is None or not cmd`. This is a purely stylistic change which doesn't alter the logic. To get a clear understanding of what's going on, I recommend reading the short "Truth Value

[issue34897] distutils test errors when CXX is not set

Michael Felt added the comment: > On 10/26/2018 5:36 PM, Tal Einat wrote: > Tal Einat added the comment: > > I'm not sure that the resolution currently suggested, changing > compiler.set_executables(), is the right way to go. > > This change to distutils is a break of backwards

[issue34897] distutils test errors when CXX is not set

Tal Einat added the comment: I'm not sure that the resolution currently suggested, changing compiler.set_executables(), is the right way to go. This change to distutils is a break of backwards compatibility. Though it is a minor change, it could still break existing code. Fixing

[issue34897] distutils test errors when CXX is not set

Change by Michael Felt : -- keywords: +patch pull_requests: +9091 stage: -> patch review ___ Python tracker ___ ___

[issue34897] distutils test errors when CXX is not set

New submission from Michael Felt : while researching issue11191 I cam across 6 additional errors. There is a test in Lib/test/support/__init__.py def missing_compiler_executable(cmd_names=[]): """Check if the compiler components used to build the interpreter exist. Check for the