[issue34932] Add macOS TCP_KEEPALIVE to available socket options

miss-islington added the comment: New changeset ff7af2203c1f03d9300e93e3e06a47fb78cc2bef by Miss Islington (bot) in branch '3.10': bpo-34932: Add socket.TCP_KEEPALIVE for macOS (GH-25079) https://github.com/python/cpython/commit/ff7af2203c1f03d9300e93e3e06a47fb78cc2bef --

[issue34932] Add macOS TCP_KEEPALIVE to available socket options

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34932] Add macOS TCP_KEEPALIVE to available socket options

Change by miss-islington : -- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +25691 pull_request: https://github.com/python/cpython/pull/27153 ___ Python tracker

[issue34932] Add macOS TCP_KEEPALIVE to available socket options

Pablo Galindo Salgado added the comment: New changeset d59d7374a364c4e5c2b9a83d8e4543ee494285b8 by Shane Harvey in branch 'main': bpo-34932: Add socket.TCP_KEEPALIVE for macOS (GH-25079) https://github.com/python/cpython/commit/d59d7374a364c4e5c2b9a83d8e4543ee494285b8 -- nosy:

[issue34932] Add macOS TCP_KEEPALIVE to available socket options

Shane Harvey added the comment: I opened a PR to add the socket.TCP_KEEPALIVE flag *on macOS only*. I don't see a reason to add it on Windows since as far as I can tell, TCP_KEEPALIVE is completely undocumented there. Besides there are already two ways to configure keepalive times on

[issue34932] Add macOS TCP_KEEPALIVE to available socket options

Change by Shane Harvey : -- nosy: +ShaneHarvey nosy_count: 3.0 -> 4.0 pull_requests: +23829 pull_request: https://github.com/python/cpython/pull/25079 ___ Python tracker ___

[issue34932] Add macOS TCP_KEEPALIVE to available socket options

Robert Wall added the comment: I saw that article too but reading man tcp(4) [1], it says that this value is in seconds for macOS and testing appears to confirm this. Where the unit of time is different, however, is with the old and new Windows keepalive options discussed in #32394. The

[issue34932] Add macOS TCP_KEEPALIVE to available socket options

Steve Dower added the comment: Yes, looks like TCP_KEEPIDLE is only available from 1709, so it should get the same handling as the TCP_KEEPCNT. If TCP_KEEPALIVE is just a synonym, then it applies for both. -- ___ Python tracker

[issue34932] Add macOS TCP_KEEPALIVE to available socket options

Ma Lin added the comment: I searched on Google, an article [1] said: Of note, Mac OS X defines keepidle and keepintvl in terms of milliseconds as opposed to Linux using seconds. On Windows, it's also seconds. Will this option make trouble for cross-platform programs? [1]

[issue34932] Add macOS TCP_KEEPALIVE to available socket options

Robert added the comment: Acknowledging the test failure and message pointing to #32394: == FAIL: test_new_tcp_flags (test.test_socket.TestMSWindowsTCPFlags)

[issue34932] Add macOS TCP_KEEPALIVE to available socket options

Change by Roundup Robot : -- keywords: +patch pull_requests: +9144 stage: -> patch review ___ Python tracker ___ ___

[issue34932] Add macOS TCP_KEEPALIVE to available socket options

New submission from Robert : macOS uses TCP_KEEPALIVE in place of TCP_KEEPIDLE. It would be good to have this available in the socket library to use directly. Pull request coming up. -- components: Library (Lib) messages: 327351 nosy: llawall priority: normal severity: normal