[issue34987] A possible null pointer dereference in _pickle.c's save_reduce()

Change by Zackery Spytz : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34987] A possible null pointer dereference in _pickle.c's save_reduce()

miss-islington added the comment: New changeset e2f376f284b7bf1388d85e99dce646cabc507016 by Miss Islington (bot) in branch '3.7': bpo-34987: Fix a possible null pointer dereference in _pickle.c's save_reduce(). (GH-9886)

[issue34987] A possible null pointer dereference in _pickle.c's save_reduce()

miss-islington added the comment: New changeset 92d912c344e6c21de46da29f0dc45b7e476fa79d by Miss Islington (bot) in branch '3.6': bpo-34987: Fix a possible null pointer dereference in _pickle.c's save_reduce(). (GH-9886)

[issue34987] A possible null pointer dereference in _pickle.c's save_reduce()

Change by miss-islington : -- pull_requests: +10188 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34987] A possible null pointer dereference in _pickle.c's save_reduce()

Change by miss-islington : -- pull_requests: +10187 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34987] A possible null pointer dereference in _pickle.c's save_reduce()

Serhiy Storchaka added the comment: New changeset 25d389789c59a52a31770f7c50ce9e02a8909190 by Serhiy Storchaka (Zackery Spytz) in branch 'master': bpo-34987: Fix a possible null pointer dereference in _pickle.c's save_reduce(). (GH-9886)

[issue34987] A possible null pointer dereference in _pickle.c's save_reduce()

Serhiy Storchaka added the comment: I was wrong. get_class() returns NULL when and only when an exception is set. -- ___ Python tracker ___

[issue34987] A possible null pointer dereference in _pickle.c's save_reduce()

Serhiy Storchaka added the comment: You are right. Although, get_class() can return NULL without set an exception. We have to set an exception in such case (the same exception as for `obj_class != cls` looks appropriate). -- ___ Python tracker

[issue34987] A possible null pointer dereference in _pickle.c's save_reduce()

Zackery Spytz added the comment: It is not properly checked: Py_DECREF() is always called on the result of get_class(), but get_class() can return NULL. -- ___ Python tracker

[issue34987] A possible null pointer dereference in _pickle.c's save_reduce()

Serhiy Storchaka added the comment: It is checked, and there is a comment about this. p = obj_class != cls;/* true iff a problem */ -- nosy: +serhiy.storchaka ___ Python tracker

[issue34987] A possible null pointer dereference in _pickle.c's save_reduce()

Change by Zackery Spytz : -- keywords: +patch pull_requests: +9249 stage: -> patch review ___ Python tracker ___ ___

[issue34987] A possible null pointer dereference in _pickle.c's save_reduce()

New submission from Zackery Spytz : The get_class() call in save_reduce() is not checked for failure. -- components: Extension Modules messages: 327732 nosy: ZackerySpytz priority: normal severity: normal status: open title: A possible null pointer dereference in _pickle.c's