[issue35011] expat: Restore the use of pyexpatns.h to avoid link time conflicts vs other versions

Benjamin Peterson added the comment: Sorry for breaking that, and thanks for the fix! I'm curious, though, why are you still using the embedded expat rather than linking everything against the same expat? -- ___ Python tracker

[issue35011] expat: Restore the use of pyexpatns.h to avoid link time conflicts vs other versions

Change by Gregory P. Smith : -- resolution: -> fixed stage: patch review -> commit review status: open -> closed ___ Python tracker ___

[issue35011] expat: Restore the use of pyexpatns.h to avoid link time conflicts vs other versions

miss-islington added the comment: New changeset 35ae99d7b394af0ce01460f7bccd7449a82289ad by Miss Islington (bot) in branch '3.7': [3.7] bpo-35011: Restore use of pyexpatns.h in libexpat (GH-9939) (GH-9940) https://github.com/python/cpython/commit/35ae99d7b394af0ce01460f7bccd7449a82289ad

[issue35011] expat: Restore the use of pyexpatns.h to avoid link time conflicts vs other versions

miss-islington added the comment: New changeset 4bfecb9298d447d5599ea76f3f68f772c38b8fd0 by Miss Islington (bot) in branch '3.6': [3.6] bpo-35011: Restore use of pyexpatns.h in libexpat (GH-9939) (GH-9941) https://github.com/python/cpython/commit/4bfecb9298d447d5599ea76f3f68f772c38b8fd0

[issue35011] expat: Restore the use of pyexpatns.h to avoid link time conflicts vs other versions

Change by miss-islington : -- pull_requests: +9292 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35011] expat: Restore the use of pyexpatns.h to avoid link time conflicts vs other versions

Change by miss-islington : -- pull_requests: +9291 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35011] expat: Restore the use of pyexpatns.h to avoid link time conflicts vs other versions

Gregory P. Smith added the comment: New changeset 9d4712bc8f26bf1d7e626b53ab092fe030bcd68d by Gregory P. Smith in branch 'master': bpo-35011: Restore use of pyexpatns.h in libexpat (GH-9939) https://github.com/python/cpython/commit/9d4712bc8f26bf1d7e626b53ab092fe030bcd68d --

[issue35011] expat: Restore the use of pyexpatns.h to avoid link time conflicts vs other versions

Change by Gregory P. Smith : -- keywords: +patch pull_requests: +9290 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue35011] expat: Restore the use of pyexpatns.h to avoid link time conflicts vs other versions

Gregory P. Smith added the comment: This appears to not have been shipped in a release yet. It is new in 3.6.7. cc'ing ned daily to see if he wants to include the fix (the PR is trivial, coming ASAP). I don't have a good feel for how this impacts the real world or not. We noticed because

[issue35011] expat: Restore the use of pyexpatns.h to avoid link time conflicts vs other versions

Gregory P. Smith added the comment: Not a release blocker as most users probably do not run into this problem, but the pyexpatns.h mechanics should be restored. -- assignee: -> gregory.p.smith components: +Build, Extension Modules nosy: +benjamin.peterson stage: -> needs patch