[issue35137] Exception in isinstance when __class__ property raises

2018-11-02 Thread Brett Cannon
Brett Cannon added the comment: I'm with Serhiy that exceptions should not be swallowed up unless there's a very good reason to, and in this instance there isn't if there's a bug in code as that low of a level as debugging that would be atrocious. -- nosy: +brett.cannon resolution:

[issue35137] Exception in isinstance when __class__ property raises

2018-11-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: MemoryError and RecursionError are subclasses of Exception. And there are may be other exceptions that can be raised by virtually any code and depend on conditions out of your control. -- ___ Python tracker

[issue35137] Exception in isinstance when __class__ property raises

2018-11-01 Thread Anthony Sottile
Anthony Sottile added the comment: arbitrary, sure, but deriving from `Exception` maybe? -- ___ Python tracker ___ ___

[issue35137] Exception in isinstance when __class__ property raises

2018-11-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Arbitrary exceptions should not be silenced. Imagine that the user pressed Ctrl-C when the __class__ property implemented in Python was executed. The KeyboardInterrupt exception will be silenced in Python 2, and isinstance() will silently return incorrect

[issue35137] Exception in isinstance when __class__ property raises

2018-11-01 Thread daniel hahler
Change by daniel hahler : -- nosy: +blueyed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35137] Exception in isinstance when __class__ property raises

2018-11-01 Thread Anthony Sottile
New submission from Anthony Sottile : This may be intentional, but the behaviour changed between python2 and python3. Want to make sure it's intentional as we're working (hacking) around this in pytest: https://github.com/pytest-dev/pytest/pull/4284 The actual impact on pytest is the use of