[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Gregory P. Smith added the comment: Nope, work remains to be done. I've got an msan buildbot system waiting but haven't had time to follow up on figuring out what remains in a while. (getting a functioning memory sanitizer build is... finnicky to say the least) --

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Ashwin Ramaswami added the comment: Can this be closed now? -- nosy: +epicfaace ___ Python tracker ___ ___ Python-bugs-list

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Gregory P. Smith added the comment: New changeset efcf08d8ca9084d8248715f0634c21b705f02ca2 by Gregory P. Smith in branch '3.7': [3.7] bpo-35214: Annotate posix calls for clang MSan. (GH-11389) (GH-11391) https://github.com/python/cpython/commit/efcf08d8ca9084d8248715f0634c21b705f02ca2

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by Gregory P. Smith : -- pull_requests: +10758 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by Gregory P. Smith : -- pull_requests: +10758, 10759 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by Gregory P. Smith : -- pull_requests: +10758, 10759, 10760 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Gregory P. Smith added the comment: New changeset 1d300ce1d8238136595c8fea76266a4755cd73a2 by Gregory P. Smith in branch 'master': bpo-35214: Annotate posix calls for clang MSan. (#11389) https://github.com/python/cpython/commit/1d300ce1d8238136595c8fea76266a4755cd73a2 --

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by Gregory P. Smith : -- pull_requests: +10755, 10756 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by Gregory P. Smith : -- pull_requests: +10755, 10756, 10757 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by Gregory P. Smith : -- pull_requests: +10755 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

miss-islington added the comment: New changeset 5d2e4b1ff2f01b6aeac2f2f302f363d3eed225fa by Miss Islington (bot) in branch '3.7': bpo-35214: Skip test_io tests that'd cause a huge malloc under msan (GH-11385) https://github.com/python/cpython/commit/5d2e4b1ff2f01b6aeac2f2f302f363d3eed225fa

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Gregory P. Smith added the comment: Status on my upcoming buildbot host after today's changes: == Tests result: FAILURE == 375 tests OK. 11 tests failed: test_asyncio test_builtin test_code test_ctypes test_ioctl test_openpty test_os test_posix test_pty test_shutil test_uuid 32

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Gregory P. Smith added the comment: New changeset e5796c42c687e1454e84dcc50e6f67db48ff69a0 by Gregory P. Smith in branch 'master': bpo-35214: Skip test_io tests that'd cause a huge malloc under msan (#11385) https://github.com/python/cpython/commit/e5796c42c687e1454e84dcc50e6f67db48ff69a0

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by Gregory P. Smith : -- pull_requests: +10742, 10743 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by Gregory P. Smith : -- pull_requests: +10742, 10743, 10744 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by Gregory P. Smith : -- pull_requests: +10742 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Gregory P. Smith added the comment: New changeset 01b9664740307b39c2907bd84cbb0b2c35be9df4 by Gregory P. Smith (Miss Islington (bot)) in branch '3.7': bpo-35214: MSan workarounds for socket, time, and test_faulthandler. (GH-11375) (GH-11378)

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Gregory P. Smith added the comment: New changeset b474e6774d60fa67d5373e361a0ed53c18b24f53 by Gregory P. Smith in branch 'master': bpo-35214: MSan workarounds for socket, time, and test_faulthandler. (GH-11375) https://github.com/python/cpython/commit/b474e6774d60fa67d5373e361a0ed53c18b24f53

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by Gregory P. Smith : -- pull_requests: +10715, 10716, 10717 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by Gregory P. Smith : -- pull_requests: +10715, 10716 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by Gregory P. Smith : -- pull_requests: +10715 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Gregory P. Smith added the comment: I believe there are still some issues to deal with. I don't want to close the issue until I've got my buildbot running. -- versions: -Python 3.6 ___ Python tracker

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Serhiy Storchaka added the comment: Is this issue completely fixed? -- nosy: +serhiy.storchaka ___ Python tracker ___ ___

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by Alexey Izbyshev : -- nosy: +izbyshev ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Gregory P. Smith added the comment: New changeset b6f4472dc4190e2fd668490d86aeefd2ab0df935 by Gregory P. Smith in branch '2.7': [2.7] bpo-35214: Fix OOB memory access in unicode escape parser (GH-10506) (GH-10538)

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by Gregory P. Smith : -- pull_requests: +9789 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

miss-islington added the comment: New changeset 9fbcb1402efab4e287f25145a69ba14c9c6dbce9 by Miss Islington (bot) in branch '3.7': [3.7] bpo-35214: Fix OOB memory access in unicode escape parser (GH-10506) (GH-10522)

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

miss-islington added the comment: New changeset fdc485a5dff8508328b4f26265d0af1ba5004597 by Miss Islington (bot) in branch '3.6': bpo-35214: Fix OOB memory access in unicode escape parser (GH-10506) https://github.com/python/cpython/commit/fdc485a5dff8508328b4f26265d0af1ba5004597

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by miss-islington : -- pull_requests: +9783 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Gregory P. Smith added the comment: New changeset 746b2d35ea47005054ed774fecaed64fab803d7d by Gregory P. Smith in branch 'master': bpo-35214: Fix OOB memory access in unicode escape parser (GH-10506) https://github.com/python/cpython/commit/746b2d35ea47005054ed774fecaed64fab803d7d

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by miss-islington : -- pull_requests: +9782 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by Gregory P. Smith : -- pull_requests: +9766 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

miss-islington added the comment: New changeset 60cf26528b931215160a53fd61836dbe4f036009 by Miss Islington (bot) in branch '3.6': bpo-35214: Add _Py_ prefix to MEMORY_SANITIZER def. (GH-10503) https://github.com/python/cpython/commit/60cf26528b931215160a53fd61836dbe4f036009 --

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

miss-islington added the comment: New changeset f6602f92664b782125a1ec5009706f9300fe7e80 by Miss Islington (bot) in branch '3.7': bpo-35214: Add _Py_ prefix to MEMORY_SANITIZER def. (GH-10503) https://github.com/python/cpython/commit/f6602f92664b782125a1ec5009706f9300fe7e80 --

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by miss-islington : -- pull_requests: +9765 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Gregory P. Smith added the comment: New changeset 3015fb8ce4d25603434b9b44bb7effb98a481532 by Gregory P. Smith in branch 'master': bpo-35214: Add _Py_ prefix to MEMORY_SANITIZER def. (GH-10503) https://github.com/python/cpython/commit/3015fb8ce4d25603434b9b44bb7effb98a481532 --

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by miss-islington : -- pull_requests: +9764 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Gregory P. Smith added the comment: > Can we prefix MEMORY_SANITIZER with _Py_? Yes, I wondered if I should do that. not that I expect anyone would ever define it to mean anything else, but that seems like the right thing to do. https://github.com/python/cpython/pull/10503 --

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by Gregory P. Smith : -- pull_requests: +9763 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Gregory P. Smith added the comment: yeah, i've been surprised how far i was able to get from an oss CPython tree and pre-built clang 7 binary installation. If you have headers installed for common libraries like libssl-dev and libreadline-dev you can't produce an interpreter that'll work

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by miss-islington : -- pull_requests: +9762 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by miss-islington : -- pull_requests: +9761 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Pablo Galindo Salgado added the comment: Thanks @alex! I will try again after linking against ASAN-compiled version of my libraries. -- ___ Python tracker ___

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Alex Gaynor added the comment: All libraries that are linked against, including libc, need to be compiled with MSAN. MSAN is not for the faint of heart. -- ___ Python tracker

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Pablo Galindo Salgado added the comment: I cannot initialize the interpreter after compiling with --with-memory-sanitizer: ❯ CC=clang ./configure --with-memory-sanitizer && make -j ❯ ./python Python 3.8.0a0 (heads/master:1584a00815, Nov 13 2018, 03:29:18) [Clang 7.0.0

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Benjamin Peterson added the comment: Can we prefix MEMORY_SANITIZER with _Py_? -- nosy: +benjamin.peterson ___ Python tracker ___

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by Pablo Galindo Salgado : -- nosy: +pablogsal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by Gregory P. Smith : -- pull_requests: +9760 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by Alex Gaynor : -- nosy: +alex ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Gregory P. Smith added the comment: New changeset 3b5b1c0931cd32253bbf2f3bd74e90ff821e026e by Gregory P. Smith in branch '3.6': [3.6] bpo-35214: Initial clang MemorySanitizer support (GH-10479) (GH-10493) https://github.com/python/cpython/commit/3b5b1c0931cd32253bbf2f3bd74e90ff821e026e

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by Gregory P. Smith : -- pull_requests: +9751 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Gregory P. Smith added the comment: New changeset 5f4d05d83fde05fed0b6554d0beee4f1c1f1d8f1 by Gregory P. Smith in branch '3.7': [3.7] bpo-35214: Initial clang MemorySanitizer support (GH-10479) (GH-10492) https://github.com/python/cpython/commit/5f4d05d83fde05fed0b6554d0beee4f1c1f1d8f1

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by Gregory P. Smith : -- pull_requests: +9749 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Gregory P. Smith added the comment: New changeset 1584a0081500d35dc93ff88e5836df35faf3e3e2 by Gregory P. Smith in branch 'master': bpo-35214: Initial clang MemorySanitizer support (GH-10479) https://github.com/python/cpython/commit/1584a0081500d35dc93ff88e5836df35faf3e3e2 --

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

Change by Gregory P. Smith : -- keywords: +patch pull_requests: +9746 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35214] Get the test suite passing with clang Memory Sanitizer enabled

New submission from Gregory P. Smith : clang's memory sanitizer (-fsanitize=memory) turns up useful problems in code. I'm working on getting a CPython buildbot running it setup but would like our build to be cleaner to start with before I run that. These are the initial fixes required for