[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

STINNER Victor added the comment: New changeset 92f90242994652d6b7afe0a2c8a61cf2bccc8c32 by Ned Deily (Miss Islington (bot)) in branch '3.7': bpo-35257: fix broken BLDSHARED - needs LDFLAGS too (GH-11297) https://github.com/python/cpython/commit/92f90242994652d6b7afe0a2c8a61cf2bccc8c32 Since

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

Ned Deily added the comment: New changeset f14087a4a96bb3f500e2d2bbc36c1124e90d5f73 by Ned Deily (Victor Stinner) in branch '3.7': bpo-35257: Avoid leaking LTO linker flags into distutils (GH-10900) (GH-11264) https://github.com/python/cpython/commit/f14087a4a96bb3f500e2d2bbc36c1124e90d5f73

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

Ned Deily added the comment: New changeset 68f5dfd955ee7a16fabf90d7c370159cc0ca9b75 by Ned Deily (Miss Islington (bot)) in branch '3.6': bpo-35257: fix broken BLDSHARED - needs LDFLAGS too (GH-11297) (GH-11299) https://github.com/python/cpython/commit/68f5dfd955ee7a16fabf90d7c370159cc0ca9b75

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

miss-islington added the comment: New changeset 3d4b4b80f290e622b05ca219ad6dabc07b49421a by Miss Islington (bot) in branch '3.7': bpo-35257: fix broken BLDSHARED - needs LDFLAGS too (GH-11297) https://github.com/python/cpython/commit/3d4b4b80f290e622b05ca219ad6dabc07b49421a --

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

Change by miss-islington : -- pull_requests: +10534 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

Change by miss-islington : -- pull_requests: +10533 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

miss-islington added the comment: New changeset 44a3ee07e30e18d83e2730c093d8b0e930f0a06c by Miss Islington (bot) (Ned Deily) in branch 'master': bpo-35257: fix broken BLDSHARED - needs LDFLAGS too (GH-11297) https://github.com/python/cpython/commit/44a3ee07e30e18d83e2730c093d8b0e930f0a06c -

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

miss-islington added the comment: New changeset 44a3ee07e30e18d83e2730c093d8b0e930f0a06c by Miss Islington (bot) (Ned Deily) in branch 'master': bpo-35257: fix broken BLDSHARED - needs LDFLAGS too (GH-11297) https://github.com/python/cpython/commit/44a3ee07e30e18d83e2730c093d8b0e930f0a06c -

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

Change by Ned Deily : -- pull_requests: +10532 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

STINNER Victor added the comment: Just in case, I checked again 3.6 and 3.7 branches with "./configure CC=clang --with-lto --enable-shared": they still pass my manual tests ;-) -- ___ Python tracker ___

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

Ned Deily added the comment: Also cherry-picked to 3.6 in commit a21bedf9edeacce6f0de3b2df0783e2ad6aa3b18 [3.6] bpo-35257: Avoid leaking LTO linker flags into distutils (GH-10900) (GH-11265) -- priority: release blocker -> resolution: -> fixed stage: patch review -> resolved status:

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

STINNER Victor added the comment: I repeated the same tests for Python 3.6 on PR 11265: all tests are ok! I replaced "38" with "36" and "3.8" and 3.6" and my 3 scripts :-) I modified step1.sh for PGO+LTO and to compile with -O0 (just to make tests faster): similar script than in my previous

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

STINNER Victor added the comment: New changeset 0198f52ea2328fd932622ad2299381f617a041f2 by Victor Stinner in branch '3.7': bpo-35257: Avoid leaking LTO linker flags into distutils (GH-10900) (GH-11264) https://github.com/python/cpython/commit/0198f52ea2328fd932622ad2299381f617a041f2 --

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

STINNER Victor added the comment: I repeated the same tests for Python 3.7 on PR 11264. I replaced "38" with "37" and "3.8" and 3.7" and my 3 scripts :-) I modified step1.sh for PGO+LTO with -O0: set -x -e git clean -fdx ./configure CC=clang --with-lto --prefix /opt/py37 --enable-optimizatio

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

Charalampos Stratakis added the comment: Small correction. This regression has been on 3.7 for some time now (since it was the master branch then), but then I requested to have the buggy commit backported to 3.6 to fix the --with-lto flag there. Which unfortunately introduced the issue to 3.

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

STINNER Victor added the comment: Ned: We have to do something with this issue before 3.6 and 3.7 releases. Either revert or backport fixes (merge PR 11264 and PR 11265). -- priority: critical -> release blocker ___ Python tracker

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

Change by STINNER Victor : -- pull_requests: +10496 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

Charalampos Stratakis added the comment: And also 3.7.2rc1 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

Charalampos Stratakis added the comment: This change fixes a regression introduced in 3.6.8rc1 with https://bugs.python.org/issue31354 -- ___ Python tracker ___ _

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

Change by STINNER Victor : -- pull_requests: +10495 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

STINNER Victor added the comment: New changeset cf10a750f4b50b6775719cfb17bee00bc3a9c60b by Victor Stinner (stratakis) in branch 'master': bpo-35257: Avoid leaking LTO linker flags into distutils (GH-10900) https://github.com/python/cpython/commit/cf10a750f4b50b6775719cfb17bee00bc3a9c60b --

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

STINNER Victor added the comment: PGO+LTO build with PR 10900: I see PGO options (-fprofile-instr-generate then -fprofile-instr-use=code.profclangd) and LTO option (-flto) passed to the compiler and to the linker, as expected: $ git clean -fdx $ ./configure CC=clang --with-lto --prefix /opt/

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

STINNER Victor added the comment: TL; DR PR 10900 passed my manual tests ;-) I made some tests on PR 10900, commit d1655f939d0eeeca24c2a4fee635da087e0d499b, using 3 shell scripts. (1) step1.sh: -- set -x -e git clean -fdx ./configure CC=clang --with-lto --prefix /opt/py38 make 2>&1|tee log g

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

Change by STINNER Victor : -- pull_requests: +10406 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

STINNER Victor added the comment: See also: * bpo-35499: "make profile-opt" overrides CFLAGS_NODIST * bpo-35501: "make coverage" should use leak coverage flags to third party C extensions. -- ___ Python tracker

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

STINNER Victor added the comment: There are multiple ways to configure and build Python, we should try most combinations: * ./configure --enable-shared * ./configure --with-lto * ./configure --enable-optimizations * make profile-opt * make * Maybe also: make install Test: * Build Python and

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

Charalampos Stratakis added the comment: The PR is pending another round of review. -- ___ Python tracker ___ ___ Python-bugs-list

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

Change by STINNER Victor : -- title: Avoid leaking linker flags into distutils. -> Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST ___ Python tracker ___