[issue35373] PyInit_timezone() must return a value

Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue35373] PyInit_timezone() must return a value

miss-islington added the comment: New changeset f455353bc0d195e092f09fec92ed16e9be02b7b1 by Miss Islington (bot) in branch '3.6': [3.7] bpo-35373: Fix PyInit_timezone() error handling (GH-10864) https://github.com/python/cpython/commit/f455353bc0d195e092f09fec92ed16e9be02b7b1 --

[issue35373] PyInit_timezone() must return a value

STINNER Victor added the comment: In Python 2.7, inittimezone() is simpler and so less likely to fail. I propose to leave Python 2.7 unchanged. -- versions: +Python 3.6, Python 3.7, Python 3.8 ___ Python tracker

[issue35373] PyInit_timezone() must return a value

Change by miss-islington : -- pull_requests: +10122 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35373] PyInit_timezone() must return a value

STINNER Victor added the comment: New changeset 5eb78c75128187a36d8e983027632fa51cc2ff4d by Victor Stinner in branch '3.7': [3.7] bpo-35373: Fix PyInit_timezone() error handling (GH-10864) https://github.com/python/cpython/commit/5eb78c75128187a36d8e983027632fa51cc2ff4d --

[issue35373] PyInit_timezone() must return a value

STINNER Victor added the comment: New changeset 3bb150d8148e3cc08418077a58f43e064b9fde61 by Victor Stinner in branch 'master': bpo-35373: Fix PyInit_time() error handling (GH-10865) https://github.com/python/cpython/commit/3bb150d8148e3cc08418077a58f43e064b9fde61 --

[issue35373] PyInit_timezone() must return a value

Change by STINNER Victor : -- pull_requests: +10101 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35373] PyInit_timezone() must return a value

STINNER Victor added the comment: Hum. By the way, PyInit_time() calls PyModule_AddObject() without checking for errors :-/ PyMODINIT_FUNC PyInit_time(void) { PyObject *m; m = PyModule_Create(); if (m == NULL) return NULL; ... PyModule_AddObject(m, "struct_time",

[issue35373] PyInit_timezone() must return a value

Change by STINNER Victor : -- pull_requests: +10100 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35373] PyInit_timezone() must return a value

STINNER Victor added the comment: New changeset ab6614969301b238fcc27f43923a0189a57a2a3c by Victor Stinner in branch 'master': bpo-35373: Fix PyInit_timezone() if HAVE_DECL_TZNAME is defined (GH-10861) https://github.com/python/cpython/commit/ab6614969301b238fcc27f43923a0189a57a2a3c

[issue35373] PyInit_timezone() must return a value

STINNER Victor added the comment: Crap. My commit 503ce5c482cb267b0770bc46c315d5cf822bdca9 was supposed to fix on of the latest compiler warning in master, but I introduced a new warning :-( What a shame on me :-( I was too quick... PR 10861 should fix the new warning. --

[issue35373] PyInit_timezone() must return a value

Change by STINNER Victor : -- keywords: +patch pull_requests: +10096 stage: -> patch review ___ Python tracker ___ ___

[issue35373] PyInit_timezone() must return a value

New submission from Serhiy Storchaka : PyInit_timezone() is declared as returning int, but it contains return statements without value. >From compiler output on Windows: timemodule.c ..\Modules\timemodule.c(1584): warning C4033: 'PyInit_timezone' must return a value