[issue35398] SQLite incorrect row count for UPDATE

Erlend E. Aasland added the comment: See also bpo-36859. -- nosy: +erlendaasland ___ Python tracker ___ ___ Python-bugs-list

[issue35398] SQLite incorrect row count for UPDATE

Change by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35398] SQLite incorrect row count for UPDATE

Montana Low added the comment: I took a stab at patch. It fixes the issue for me, as proven via the Test Case. -- ___ Python tracker ___

[issue35398] SQLite incorrect row count for UPDATE

Change by Roundup Robot : -- keywords: +patch pull_requests: +10152 stage: -> patch review ___ Python tracker ___ ___

[issue35398] SQLite incorrect row count for UPDATE

Karthikeyan Singaravelan added the comment: Did some debugging here. If I am understanding this correctly the rowcount is set at https://github.com/python/cpython/blob/b8e689a6e8134e88f857a55e50b6a4977967e385/Modules/_sqlite/cursor.c#L574 . It checks for is_dml flag that is set here

[issue35398] SQLite incorrect row count for UPDATE

Change by Lysandros Nikolaou : -- nosy: +lys.nikolaou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35398] SQLite incorrect row count for UPDATE

Change by Karthikeyan Singaravelan : -- nosy: +ghaering, xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35398] SQLite incorrect row count for UPDATE

Change by mike bayer : -- nosy: +zzzeek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35398] SQLite incorrect row count for UPDATE

New submission from Montana Low : SQLite driver returns an incorrect row count (-1) for UPDATE statements that begin with a comment. Downstream Reference: https://github.com/sqlalchemy/sqlalchemy/issues/4396 Test Case: ``` import sqlite3 conn = sqlite3.connect(":memory:") cursor =