[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

Pablo Galindo Salgado added the comment: @Steve, we are investigating and tracking this issue here: https://bugs.python.org/issue35795 According to the buildbot owner "directory tree removal needs to go through support.rmtree, not any of the stdlib methods for doing so. In a nutshell, the

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

Tzu-ping Chung added the comment: I read a few of the logs, and all errors roots in the same place, when the test case tries to remove the tempdir during teardown/cleanup. The Windows (and other platforms not supporting directory fds) implementation of rmtree can have race conditions if

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

Steve Dower added the comment: There is one buildbot (https://buildbot.python.org/all/#builders/40/builds/1524) that started randomly failing unrelated tests with this change - usually one of zipapp, pkgutil, or zipimport. I don't have any idea what the relationship here is, unless the

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

Ned Deily added the comment: Merged on behalf of Steve. Thanks, Marc! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

miss-islington added the comment: New changeset 2fa53cfa8960f4bcb36718da4424e980fc305ef5 by Miss Islington (bot) in branch '3.7': bpo-35699: fix distuils cannot detect Build Tools 2017 anymore (GH-11495) https://github.com/python/cpython/commit/2fa53cfa8960f4bcb36718da4424e980fc305ef5

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

Change by miss-islington : -- pull_requests: +11389, 11390, 11391 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

Change by miss-islington : -- pull_requests: +11389, 11390 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

Change by miss-islington : -- pull_requests: +11389 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

Ned Deily added the comment: New changeset b2dc4a3313c236fedbd6df664722cd47f3d91a72 by Ned Deily (Marc Schlaich) in branch 'master': bpo-35699: fix distuils cannot detect Build Tools 2017 anymore (GH-11495) https://github.com/python/cpython/commit/b2dc4a3313c236fedbd6df664722cd47f3d91a72

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

Steve Dower added the comment: Reminder to myself (or permission for anyone else) to merge this. My phone won't let me actually click the github merge button, unfortunately, but this seems good to go. -- ___ Python tracker

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

Change by Tzu-ping Chung : -- nosy: +uranusjr ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

Change by Marc Schlaich : -- keywords: +patch, patch pull_requests: +11016, 11017 stage: -> patch review ___ Python tracker ___

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

Change by Marc Schlaich : -- keywords: +patch, patch, patch pull_requests: +11016, 11017, 11018 stage: -> patch review ___ Python tracker ___

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

Change by Marc Schlaich : -- keywords: +patch pull_requests: +11016 stage: -> patch review ___ Python tracker ___ ___

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

Marc Schlaich added the comment: We are passing arguments -latest(Return only the newest version and last installed.) and "-requires", "Microsoft.VisualStudio.Component.VC.Tools.x86.x64", So this should handle the cases multiple installs and different products without compilers.

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

Steve Dower added the comment: Excellent catch! Are you interested in creating a PR? Also, I don't recall whether we are handling multiple installs or not, but if we are not I would rather explicitly list the products that may include compilers than using "*" (since there are and will be

[issue35699] distutils cannot find Build Tools 2017 since 3.7.2

New submission from Marc Schlaich : vshwere.exe doesn't return Build Tools 2017 per default. This means Build Tools 2017 are not detected by distutils in 3.7.2 and you get the famous "Microsoft Visual C++ 14.0 is required" error. Please see https://github.com/Microsoft/vswhere/issues/125 for