[issue35835] There is no mention of breakpoint() in the pdb documentation

miss-islington added the comment: New changeset 7516f265a8517e4fdc7d6e63d72ae1b57fda26ee by Miss Islington (bot) in branch '3.7': bpo-35835: Add reference to Python 3.7 new breakpoint() function in pdb documentation. (GH-11691) https://github.com/python/cpython/commit/7516f265a8517e4fdc7d6e6

[issue35835] There is no mention of breakpoint() in the pdb documentation

jcrmatos added the comment: Thank you all for the help. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue35835] There is no mention of breakpoint() in the pdb documentation

Change by miss-islington : -- pull_requests: +11555, 11556 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue35835] There is no mention of breakpoint() in the pdb documentation

Mariatta Wijaya added the comment: Thanks! -- nosy: +Mariatta resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue35835] There is no mention of breakpoint() in the pdb documentation

Change by miss-islington : -- pull_requests: +11555, 11556, 11557 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue35835] There is no mention of breakpoint() in the pdb documentation

miss-islington added the comment: New changeset cf991e653ac550a9f011631447c61ce583404a57 by Miss Islington (bot) (João Matos) in branch 'master': bpo-35835: Add reference to Python 3.7 new breakpoint() function in pdb documentation. (GH-11691) https://github.com/python/cpython/commit/cf991e65

[issue35835] There is no mention of breakpoint() in the pdb documentation

Change by miss-islington : -- pull_requests: +11555 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue35835] There is no mention of breakpoint() in the pdb documentation

jcrmatos added the comment: I deleted the fork and started again. This time I didn't PR to my own fork but to cpython master. It is now waiting for review, "skip news" labeling and CLA (I'm still waiting on my request). -- ___ Python tracker

[issue35835] There is no mention of breakpoint() in the pdb documentation

Change by jcrmatos : -- keywords: +patch, patch, patch, patch pull_requests: +11532, 11533, 11534, 11535 stage: needs patch -> patch review ___ Python tracker ___ _

[issue35835] There is no mention of breakpoint() in the pdb documentation

Change by jcrmatos : -- keywords: +patch, patch, patch pull_requests: +11532, 11533, 11534 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue35835] There is no mention of breakpoint() in the pdb documentation

Change by jcrmatos : -- keywords: +patch pull_requests: +11532 stage: needs patch -> patch review ___ Python tracker ___ ___ Python-

[issue35835] There is no mention of breakpoint() in the pdb documentation

Change by jcrmatos : -- keywords: +patch, patch pull_requests: +11532, 11533 stage: needs patch -> patch review ___ Python tracker ___ _

[issue35835] There is no mention of breakpoint() in the pdb documentation

Cheryl Sabella added the comment: As Karthikeyan said, you do need to open a PR against the CPython master. I'm not a Git expert, but this page (section 3.3) discusses the steps to open that PR: https://devguide.python.org/pullrequest/ Those are the steps I follow and it's a good write-up s

[issue35835] There is no mention of breakpoint() in the pdb documentation

jcrmatos added the comment: Hello, I didn't do anything locally. I did the change and preview it on GitHub's web interface. Has I said, I did a PR to my own fork and now I think I have to do a PR to the cpython master. Is that correct? The PR to my own fork was required, or the commit was e

[issue35835] There is no mention of breakpoint() in the pdb documentation

Cheryl Sabella added the comment: @jcrmatos - Sounds like you're on the right track. :-) Based on the steps you've outlined, I just had one question. Were you able to rebuild the docs locally in order to see how your changes looked? Here's the direct link to building the docs: https://dev

[issue35835] There is no mention of breakpoint() in the pdb documentation

jcrmatos added the comment: Hello, Yes, I signed the CLA and now I have to wait at least 1 business day. So I will wait for that confirmation before making the PR to the CPython repo. Thanks, JM -- ___ Python tracker

[issue35835] There is no mention of breakpoint() in the pdb documentation

Karthikeyan Singaravelan added the comment: @jcrmatos yes, you should be making a PR to CPython repo's master branch since GitHub PRs are accepted. I hope also need to sign the CLA for your contribution to get merged though it's a documentation fix. Thanks -- __

[issue35835] There is no mention of breakpoint() in the pdb documentation

jcrmatos added the comment: Hello, On the previous message I forgot to mention that the pull request was made in my fork, not the cpython repo. Should I made a PR in the cpython repo at this point? Thanks, JM -- ___ Python tracker

[issue35835] There is no mention of breakpoint() in the pdb documentation

jcrmatos added the comment: Hello, I'm using Github web interface. I did these steps: - Forked cpython and changed the pdb.rst file. - Created a branch called "fix-issue-35835". - Made the commit with description "Add reference to Python 3.7 new function breakpoint()". - Made the pull request

[issue35835] There is no mention of breakpoint() in the pdb documentation

jcrmatos added the comment: Hello, Yes, I'm interested in learning, thanks. I use Windows not Linux. Is that a problem? I will read the guide and let you know if I have any questions. Thanks again. JM -- ___ Python tracker

[issue35835] There is no mention of breakpoint() in the pdb documentation

Cheryl Sabella added the comment: @jcrmatos, No problem. :-) If you are interested in learning how, we can guide you. However, if you'd rather not, then that's OK too and we'll make the patch. Just let us know which you'd prefer. If you need help deciding, take a look at the devguide on

[issue35835] There is no mention of breakpoint() in the pdb documentation

Change by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue35835] There is no mention of breakpoint() in the pdb documentation

jcrmatos added the comment: Hello, I'm sorry, I have no idea how to do it. JM -- ___ Python tracker ___ ___ Python-bugs-list mail

[issue35835] There is no mention of breakpoint() in the pdb documentation

Cheryl Sabella added the comment: @jcrmatos, would you like to create a Github pull request with the change? -- ___ Python tracker ___

[issue35835] There is no mention of breakpoint() in the pdb documentation

Karthikeyan Singaravelan added the comment: I am ok with Cheryl's idea too. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue35835] There is no mention of breakpoint() in the pdb documentation

jcrmatos added the comment: Hello, In my first message I said exactly that (the replacement used the previous text, if you check it). I'm ok with the wording from Cheryl. How about you Karthikeyan? Thanks, JM -- ___ Python tracker

[issue35835] There is no mention of breakpoint() in the pdb documentation

Cheryl Sabella added the comment: I agree with Karthikeyan. If it's added to the pdb doc page, I think the existing text should stay as it is, but a 'New in 3.7' added after it. Something like: The typical usage to break into the debugger from a running program is to insert import pdb; pdb

[issue35835] There is no mention of breakpoint() in the pdb documentation

Karthikeyan Singaravelan added the comment: I didn't want the doc to sound like breakpoint() is encouraged since it's optional and a shortcut. Hence my personal preference to just add a note with link to breakpoint() that it does the same thing. I will wait for someone else to rephrase it be

[issue35835] There is no mention of breakpoint() in the pdb documentation

jcrmatos added the comment: Hello, What about like this import pdb; pdb.set_trace() New in version 3.7: breakpoint() is preferable to using the previous line. Thanks, JM -- ___ Python tracker

[issue35835] There is no mention of breakpoint() in the pdb documentation

Karthikeyan Singaravelan added the comment: > New in version 3.7: breakpoint() replaces the previous line. replaces sounds little more like removed or deprecated to me. How about the below under pdb.set_trace() doc and example using it in the beginning? New in version 3.7: breakpoint() is a

[issue35835] There is no mention of breakpoint() in the pdb documentation

Change by SilentGhost : -- assignee: -> docs@python components: +Documentation nosy: +docs@python stage: -> needs patch ___ Python tracker ___ ___

[issue35835] There is no mention of breakpoint() in the pdb documentation

New submission from jcrmatos : In the Pdb documentation, found at https://docs.python.org/3.7/library/pdb.html?highlight=pdb#module-pdb there is no mention of breakpoint(). In my opinion, this text import pdb; pdb.set_trace() should be replaced with import pdb; pdb.set_trace() New in version