[issue35887] Doc string for updating the frozen version of importlib in _bootstrap.py incorrect

2019-02-14 Thread Brett Cannon
Change by Brett Cannon : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue35887] Doc string for updating the frozen version of importlib in _bootstrap.py incorrect

2019-02-13 Thread Brett Cannon
Brett Cannon added the comment: New changeset 1dc5cb9cb3447211069a7788208254b1cfa8ec98 by Brett Cannon (Nina Zakharenko) in branch 'master': bpo-35887: Add make regen-importlib step to importlib._bootstrap docstring (GH-11777) https://github.com/python/cpython/commit/1dc5cb9cb3447211069a7788

[issue35887] Doc string for updating the frozen version of importlib in _bootstrap.py incorrect

2019-02-06 Thread Nina Zakharenko
Change by Nina Zakharenko : -- keywords: +patch, patch pull_requests: +11753, 11754 stage: -> patch review ___ Python tracker ___ _

[issue35887] Doc string for updating the frozen version of importlib in _bootstrap.py incorrect

2019-02-06 Thread Nina Zakharenko
Change by Nina Zakharenko : -- keywords: +patch, patch, patch pull_requests: +11753, 11754, 11755 stage: -> patch review ___ Python tracker ___ ___

[issue35887] Doc string for updating the frozen version of importlib in _bootstrap.py incorrect

2019-02-06 Thread Nina Zakharenko
Change by Nina Zakharenko : -- keywords: +patch pull_requests: +11753 stage: -> patch review ___ Python tracker ___ ___ Python-bugs

[issue35887] Doc string for updating the frozen version of importlib in _bootstrap.py incorrect

2019-02-04 Thread Rémi Lapeyre
Rémi Lapeyre added the comment: I believe this is why Travis does a `make regen-all` to be sure everything is up to date. A patch to keep instructions up-to-date would be nice, newcomers are not familiar with all `make regen-*` commands. -- nosy: +remi.lapeyre __

[issue35887] Doc string for updating the frozen version of importlib in _bootstrap.py incorrect

2019-02-01 Thread Nina Zakharenko
New submission from Nina Zakharenko : In the process of creating a fix for issue #35321, I noticed what I believe to be a documentation omission. In Lib/importlib/_bootstrap.py the top level comment states that: # IMPORTANT: Whenever making changes to this module, be sure to run # a top-leve