[issue36212] [2.7] Coverity scan: Modules/_hotshot.c , Variable "s1" going out of scope leaks the storage it points to.

2019-03-14 Thread STINNER Victor
STINNER Victor added the comment: New changeset 2832ad53358e3fbc4bdc601b9f3fa04dd0deae46 by Victor Stinner (stratakis) in branch '2.7': [2.7] bpo-36212: Fix two possible reference leaks in the hotshot module (GH-12327) https://github.com/python/cpython/commit/2832ad53358e3fbc4bdc601b9f3fa04d

[issue36212] [2.7] Coverity scan: Modules/_hotshot.c , Variable "s1" going out of scope leaks the storage it points to.

2019-03-14 Thread STINNER Victor
STINNER Victor added the comment: Thanks Charalampos, I merged your PR. I made minor changes in your commit message. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue36212] [2.7] Coverity scan: Modules/_hotshot.c , Variable "s1" going out of scope leaks the storage it points to.

2019-03-14 Thread STINNER Victor
STINNER Victor added the comment: Note for myself: Python 3 isn't affected, _hotshot module has been removed from Python 3. -- nosy: +vstinner ___ Python tracker ___

[issue36212] [2.7] Coverity scan: Modules/_hotshot.c , Variable "s1" going out of scope leaks the storage it points to.

2019-03-14 Thread Charalampos Stratakis
Change by Charalampos Stratakis : -- keywords: +patch pull_requests: +12298 stage: -> patch review ___ Python tracker ___ ___ Pytho

[issue36212] [2.7] Coverity scan: Modules/_hotshot.c , Variable "s1" going out of scope leaks the storage it points to.

2019-03-06 Thread Charalampos Stratakis
New submission from Charalampos Stratakis : Coverity scan reports a leak on _hotshot.c: Python-2.7.15/Modules/_hotshot.c:442: alloc_arg: "unpack_string" allocates memory that is stored into "s1". Python-2.7.15/Modules/_hotshot.c:329:5: alloc_fn: Storage is returned from allocation function "