[issue3625] test issues on 64bit windows

2008-08-22 Thread Mark Hammond
Mark Hammond <[EMAIL PROTECTED]> added the comment: Thanks. Checked into the trunk in r65986 -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3625] test issues on 64bit windows

2008-08-22 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Mark, your patch is ok to me. You can check it in. ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue3625] test issues on 64bit windows

2008-08-21 Thread Mark Hammond
Mark Hammond <[EMAIL PROTECTED]> added the comment: I forgot about sys.maxsize - that makes things much cleaner, and even means I don't need to skip the check for insane amounts of memory. If you think this is OK, please also specifically say if you approve for me to check it into trunk for 2.6.

[issue3625] test issues on 64bit windows

2008-08-21 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Mark, that check looks fragile: +IS32BIT = sys.maxint == 0x7fff and "64 bit" not in sys.version Why don't you check for sys.maxsize instead? By construction, sys.maxsize should give you the pointer width (minus the sign bit ;-)). --

[issue3625] test issues on 64bit windows

2008-08-20 Thread Mark Hammond
New submission from Mark Hammond <[EMAIL PROTECTED]>: A number of tests are designed to be skipped on 64bits, but they don't detect 64bit windows builds as 64bits. Also, test_bytes.test_repeat() assumes sys.maxint bytes can't be allocated, which isn't necessarily true on Win64. I'm attaching a