[issue36302] distutils creates unreproducible .so files

STINNER Victor added the comment: > Why do we need to sort those extensions by name? Because calling sorted() is easy. Any other arbitrary choice would make sense. But giving the ability to build sources in a specific order, add dependencies, or something else, would a new features. Also,

[issue36302] distutils creates unreproducible .so files

Matej Cepl added the comment: > In particular, I sort the source list by age when working on larger > extensions, this makes sure that the source files I edited last get compiled > first, which speeds up edit/build cycles. On the one hand, this sounds creepily like https://xkcd.com/1172, but

[issue36302] distutils creates unreproducible .so files

Ronald Oussoren added the comment: That's the problem with any change to distutils, the API is unclear and that causes any change to be potentially breaking for existing users. That's why distutils has been mostly stagnant for years. I have no particular wish w.r.t. changing behaviour, I've

[issue36302] distutils creates unreproducible .so files

STINNER Victor added the comment: > An unfortunate side effect of this change is that changes the build order > even if the source list order is relevant. That sounds like a new feature. I don't think that it was supported previously. Or maybe it was more an implementation detail. Please

[issue36302] distutils creates unreproducible .so files

Ronald Oussoren added the comment: An unfortunate side effect of this change is that changes the build order even if the source list order is relevant. In particular, I sort the source list by age when working on larger extensions, this makes sure that the source files I edited last get

[issue36302] distutils creates unreproducible .so files

STINNER Victor added the comment: I'm not excited about backporting this change to Python 3.8 and older. Python 3.8 also switch to its feature freeze for Python 3.8.0. This change is borderline between bugfix and feature. In case of doubt, I prefer to do nothing. See concerns in the PR

[issue36302] distutils creates unreproducible .so files

STINNER Victor added the comment: New changeset 0d30ae1a03102de07758650af9243fd31211325a by Victor Stinner (Bernhard M. Wiedemann) in branch 'master': bpo-36302: Sort list of sources (GH-12341) https://github.com/python/cpython/commit/0d30ae1a03102de07758650af9243fd31211325a --

[issue36302] distutils creates unreproducible .so files

Change by Bernhard M. Wiedemann : -- keywords: +patch pull_requests: +12308 stage: -> patch review ___ Python tracker ___ ___

[issue36302] distutils creates unreproducible .so files

New submission from Bernhard M. Wiedemann : While working on reproducible builds for openSUSE, I found countless python modules that come with binary .so files that did not build reproducibly from non-deterministic filesystem readdir order. One contributing factor is bpo-30461 that will not