[issue36346] Prepare for removing the legacy Unicode C API

Change by Inada Naoki : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue36346] Prepare for removing the legacy Unicode C API

Inada Naoki added the comment: No. I just waiting Python 3.11 become Bata. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue36346] Prepare for removing the legacy Unicode C API

Irit Katriel added the comment: Is there anything left to do here? -- nosy: +iritkatriel ___ Python tracker ___ ___

[issue36346] Prepare for removing the legacy Unicode C API

Carol Willing added the comment: New changeset 346afeb159a5a8b2e260d3de740019b64352660e by Miss Islington (bot) in branch '3.8': bpo-36346: Document removal schedule of deprecate APIs (GH-20879) (#24626) https://github.com/python/cpython/commit/346afeb159a5a8b2e260d3de740019b64352660e

[issue36346] Prepare for removing the legacy Unicode C API

miss-islington added the comment: New changeset 93853b73b666a0ffbf5aaee8894659580581f7d3 by Miss Islington (bot) in branch '3.9': bpo-36346: Document removal schedule of deprecate APIs (GH-20879) https://github.com/python/cpython/commit/93853b73b666a0ffbf5aaee8894659580581f7d3 --

[issue36346] Prepare for removing the legacy Unicode C API

Change by miss-islington : -- pull_requests: +23410 pull_request: https://github.com/python/cpython/pull/24626 ___ Python tracker ___

[issue36346] Prepare for removing the legacy Unicode C API

Change by miss-islington : -- pull_requests: +23409 pull_request: https://github.com/python/cpython/pull/24625 ___ Python tracker ___

[issue36346] Prepare for removing the legacy Unicode C API

Inada Naoki added the comment: New changeset 2d6f2eed14ff5d89155b52771cc8ef957e8145b4 by Inada Naoki in branch 'master': bpo-36346: Document removal schedule of deprecate APIs (GH-20879) https://github.com/python/cpython/commit/2d6f2eed14ff5d89155b52771cc8ef957e8145b4 --

[issue36346] Prepare for removing the legacy Unicode C API

Inada Naoki added the comment: New changeset 91a639a094978882caef91915c932fbb2fc347de by Inada Naoki in branch 'master': bpo-36346: Emit DeprecationWarning for PyArg_Parse() with 'u' or 'Z'. (GH-20927) https://github.com/python/cpython/commit/91a639a094978882caef91915c932fbb2fc347de

[issue36346] Prepare for removing the legacy Unicode C API

miss-islington added the comment: New changeset f0e030cacb940f061e0b09efbffc2fd984b95259 by Miss Islington (bot) in branch '3.8': bpo-36346: Doc: Update removal schedule of legacy Unicode (GH-21479) https://github.com/python/cpython/commit/f0e030cacb940f061e0b09efbffc2fd984b95259

[issue36346] Prepare for removing the legacy Unicode C API

miss-islington added the comment: New changeset ea680631b478f091a171dc802d861f5014f58c8f by Miss Islington (bot) in branch '3.9': bpo-36346: Doc: Update removal schedule of legacy Unicode (GH-21479) https://github.com/python/cpython/commit/ea680631b478f091a171dc802d861f5014f58c8f

[issue36346] Prepare for removing the legacy Unicode C API

Change by miss-islington : -- pull_requests: +20884 pull_request: https://github.com/python/cpython/pull/21738 ___ Python tracker ___

[issue36346] Prepare for removing the legacy Unicode C API

Change by miss-islington : -- pull_requests: +20885 pull_request: https://github.com/python/cpython/pull/21739 ___ Python tracker ___

[issue36346] Prepare for removing the legacy Unicode C API

Inada Naoki added the comment: New changeset 270b4ad4df795783d417ba15080da8f95e598689 by Inada Naoki in branch 'master': bpo-36346: Doc: Update removal schedule of legacy Unicode (GH-21479) https://github.com/python/cpython/commit/270b4ad4df795783d417ba15080da8f95e598689 --

[issue36346] Prepare for removing the legacy Unicode C API

Change by Inada Naoki : -- pull_requests: +20622 pull_request: https://github.com/python/cpython/pull/21479 ___ Python tracker ___

[issue36346] Prepare for removing the legacy Unicode C API

Serhiy Storchaka added the comment: New changeset 4c8f09d7cef8c7aa07d5b5232b5b64f63819a743 by Serhiy Storchaka in branch 'master': bpo-36346: Make using the legacy Unicode C API optional (GH-21437) https://github.com/python/cpython/commit/4c8f09d7cef8c7aa07d5b5232b5b64f63819a743 --

[issue36346] Prepare for removing the legacy Unicode C API

Change by Serhiy Storchaka : -- pull_requests: +20584 pull_request: https://github.com/python/cpython/pull/21437 ___ Python tracker ___

[issue36346] Prepare for removing the legacy Unicode C API

Serhiy Storchaka added the comment: New changeset d878349bac6c154fbfeffe7d4b38e2ddb833f135 by Serhiy Storchaka in branch 'master': bpo-36346: Do not use legacy Unicode C API in ctypes. (#21429) https://github.com/python/cpython/commit/d878349bac6c154fbfeffe7d4b38e2ddb833f135 --

[issue36346] Prepare for removing the legacy Unicode C API

Change by Serhiy Storchaka : -- pull_requests: +20576 pull_request: https://github.com/python/cpython/pull/21429 ___ Python tracker ___

[issue36346] Prepare for removing the legacy Unicode C API

Serhiy Storchaka added the comment: New changeset b3dd5cd4a36877c473417fd7b3358843dcf8e647 by Serhiy Storchaka in branch 'master': bpo-36346: Undeprecate private function _PyUnicode_AsUnicode(). (GH-21336) https://github.com/python/cpython/commit/b3dd5cd4a36877c473417fd7b3358843dcf8e647

[issue36346] Prepare for removing the legacy Unicode C API

Change by Serhiy Storchaka : -- pull_requests: +20484 pull_request: https://github.com/python/cpython/pull/21336 ___ Python tracker ___

[issue36346] Prepare for removing the legacy Unicode C API

Serhiy Storchaka added the comment: There is no need to deprecate _PyUnicode_AsUnicode. It is a private function. Undeprecating it will make the code clearer. -- ___ Python tracker

[issue36346] Prepare for removing the legacy Unicode C API

Inada Naoki added the comment: New changeset 038dd0f79dc89566b01ba66a5a018266b2917a19 by Inada Naoki in branch 'master': bpo-36346: Raise DeprecationWarning when creating legacy Unicode (GH-20933) https://github.com/python/cpython/commit/038dd0f79dc89566b01ba66a5a018266b2917a19 --

[issue36346] Prepare for removing the legacy Unicode C API

Serhiy Storchaka added the comment: New changeset 349f76c6aace5a4a2b57f6b442a532faf0027d6b by Serhiy Storchaka in branch 'master': bpo-36346: Prepare for removing the legacy Unicode C API (AC only). (GH-21223) https://github.com/python/cpython/commit/349f76c6aace5a4a2b57f6b442a532faf0027d6b

[issue36346] Prepare for removing the legacy Unicode C API

Change by Serhiy Storchaka : -- pull_requests: +20375 pull_request: https://github.com/python/cpython/pull/21223 ___ Python tracker ___

[issue36346] Prepare for removing the legacy Unicode C API

Inada Naoki added the comment: New changeset 610a60c601fb4380eee30e15be1cd4dcbdaeec4c by Inada Naoki in branch '3.9': bpo-36346: Add Py_DEPRECATED to deprecated unicode APIs (GH-20878) https://github.com/python/cpython/commit/610a60c601fb4380eee30e15be1cd4dcbdaeec4c --

[issue36346] Prepare for removing the legacy Unicode C API

Change by Inada Naoki : -- pull_requests: +20122 pull_request: https://github.com/python/cpython/pull/20941 ___ Python tracker ___

[issue36346] Prepare for removing the legacy Unicode C API

Change by hai shi : -- nosy: +shihai1991 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36346] Prepare for removing the legacy Unicode C API

Inada Naoki added the comment: New changeset 8e34e92caa73259620dd242b92d26edd0949b4ba by Inada Naoki in branch 'master': bpo-36346: Make unicodeobject.h C89 compatible (GH-20934) https://github.com/python/cpython/commit/8e34e92caa73259620dd242b92d26edd0949b4ba --

[issue36346] Prepare for removing the legacy Unicode C API

STINNER Victor added the comment: > Oh, why I can not use C99? PEP 7 requires C99 to build Python, but I think that we can try to keep C89 compatibility for the public header files (Python C API). -- ___ Python tracker

[issue36346] Prepare for removing the legacy Unicode C API

Change by Inada Naoki : -- pull_requests: +20113 pull_request: https://github.com/python/cpython/pull/20934 ___ Python tracker ___

[issue36346] Prepare for removing the legacy Unicode C API

Inada Naoki added the comment: Oh, why I can not use C99? ``` /home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le/build/Include/cpython/unicodeobject.h: In function ‘Py_UNICODE_FILL’: /home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le/build/Include/cpython/unicodeobject.h:56:5: error: ‘for’

[issue36346] Prepare for removing the legacy Unicode C API

STINNER Victor added the comment: > bpo-36346: Add Py_DEPRECATED to deprecated unicode APIs (GH-20878) This change broke test_distutils on multiple buildbots. Examples: * https://buildbot.python.org/all/#builders/6/builds/1311 * https://buildbot.python.org/all/#builders/639/builds/729

[issue36346] Prepare for removing the legacy Unicode C API

Change by Inada Naoki : -- pull_requests: +20112 pull_request: https://github.com/python/cpython/pull/20933 ___ Python tracker ___

[issue36346] Prepare for removing the legacy Unicode C API

Change by miss-islington : -- nosy: +miss-islington nosy_count: 9.0 -> 10.0 pull_requests: +20111 pull_request: https://github.com/python/cpython/pull/20932 ___ Python tracker

[issue36346] Prepare for removing the legacy Unicode C API

Inada Naoki added the comment: New changeset 2c4928d37edc5e4aeec3c0b79fa3460b1ec9b60d by Inada Naoki in branch 'master': bpo-36346: Add Py_DEPRECATED to deprecated unicode APIs (GH-20878) https://github.com/python/cpython/commit/2c4928d37edc5e4aeec3c0b79fa3460b1ec9b60d --

[issue36346] Prepare for removing the legacy Unicode C API

Change by Inada Naoki : -- pull_requests: +20106 pull_request: https://github.com/python/cpython/pull/20927 ___ Python tracker ___

[issue36346] Prepare for removing the legacy Unicode C API

Change by Inada Naoki : -- pull_requests: +20066 pull_request: https://github.com/python/cpython/pull/20879 ___ Python tracker ___

[issue36346] Prepare for removing the legacy Unicode C API

Change by Inada Naoki : -- pull_requests: +20065 pull_request: https://github.com/python/cpython/pull/20878 ___ Python tracker ___

[issue36346] Prepare for removing the legacy Unicode C API

STINNER Victor added the comment: > bpo-36346: array: Don't use deprecated APIs (GH-19653) Thanks INADA-san! Another nail into Py_UNICODE coffin! -- ___ Python tracker ___

[issue36346] Prepare for removing the legacy Unicode C API

Inada Naoki added the comment: New changeset d5d9a718662e67e2b1ac7874dda9df2d8d71d415 by Inada Naoki in branch 'master': bpo-36346: array: Don't use deprecated APIs (GH-19653) https://github.com/python/cpython/commit/d5d9a718662e67e2b1ac7874dda9df2d8d71d415 --

[issue36346] Prepare for removing the legacy Unicode C API

Change by Dong-hee Na : -- nosy: +corona10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36346] Prepare for removing the legacy Unicode C API

Change by Inada Naoki : -- pull_requests: +18979 pull_request: https://github.com/python/cpython/pull/19653 ___ Python tracker ___

[issue36346] Prepare for removing the legacy Unicode C API

Change by STINNER Victor : -- components: +C API ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36346] Prepare for removing the legacy Unicode C API

STINNER Victor added the comment: I closed bpo-38604 as a duplicate. Copy of my messages. msg355475 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2019-10-27 16:02 Python 3.3 deprecated the C API functions using Py_UNICODE type. Examples in the doc: *

[issue36346] Prepare for removing the legacy Unicode C API

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36346] Prepare for removing the legacy Unicode C API

Inada Naoki added the comment: I think these ABI incompatible options are used many people. But it is helpful to find extensions which using legacy APIs before Python 3.10 is released. I had found ujson and MarkupSafe used legacy APIs. I fixed MarkupSafe. I don't care ujson because it is

[issue36346] Prepare for removing the legacy Unicode C API

Antoine Pitrou added the comment: > The proposed PR adds two compile time options: HAVE_UNICODE_WCHAR_CACHE and > USE_UNICODE_WCHAR_CACHE I don't think this is a good approach. Most projects and developers don't recompile Python. It's especially a chore when you have many dependencies

[issue36346] Prepare for removing the legacy Unicode C API

Change by Serhiy Storchaka : -- dependencies: +Refactor getenvironment() in _winapi.c ___ Python tracker ___ ___ Python-bugs-list

[issue36346] Prepare for removing the legacy Unicode C API

Ronald Oussoren added the comment: One thing to keep in mind: HAVE_UNICODE_WCHAR_CACHE == 1 and HAVE_UNICODE_WCHAR_CACHE == 0 have a different ABI due to a different struct layout. This should probably affect the ABI tag for extension modules. -- nosy: +ronaldoussoren

[issue36346] Prepare for removing the legacy Unicode C API

Inada Naoki added the comment: FYI, I had created PR 12340 which removes use of deprecated API in ctypes. -- ___ Python tracker ___

[issue36346] Prepare for removing the legacy Unicode C API

Serhiy Storchaka added the comment: I wrote this PR just to see how much code should be changed after removing the wchar_t cache, and what be performance impact. Get it, experiment with it, run tests and benchmarks. I think we could set USE_UNICODE_WCHAR_CACHE to 0 by default. If this will

[issue36346] Prepare for removing the legacy Unicode C API

Inada Naoki added the comment: I'm not sure we need two options. Does USE_UNICODE_WCHAR_CACHE=0 really helps preparing to the removal? -- ___ Python tracker ___

[issue36346] Prepare for removing the legacy Unicode C API

Marc-Andre Lemburg added the comment: On 18.03.2019 22:33, Stefan Behnel wrote: > > I had also looked through the unrelated changes, and while, yes, they are > unrelated, they seemed to be correct and reasonable modernisations of the > code base while touching it. They could be moved to a

[issue36346] Prepare for removing the legacy Unicode C API

Stefan Behnel added the comment: I had also looked through the unrelated changes, and while, yes, they are unrelated, they seemed to be correct and reasonable modernisations of the code base while touching it. They could be moved to a separate PR, but there is a relatively high risk of

[issue36346] Prepare for removing the legacy Unicode C API

Marc-Andre Lemburg added the comment: I'd change the title of this bpo item to "Prepare for removing the whcar_t caching in the Unicode C API". Note that the wchar_t caching was put in place to allow for external applications and C code to easily and efficiently interface with Python. By

[issue36346] Prepare for removing the legacy Unicode C API

Stefan Behnel added the comment: I think this is a good preparation that makes it clear what code will eventually be removed, and allows testing without it. No idea how happy Windows users will be about all of this, but I consider it quite an overall improvement for the Unicode

[issue36346] Prepare for removing the legacy Unicode C API

Stefan Behnel added the comment: Thanks for implementing this, Serhiy. Since these C macros are public, should they be named PY_* ? -- ___ Python tracker ___

[issue36346] Prepare for removing the legacy Unicode C API

Change by Stefan Behnel : -- nosy: +scoder ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36346] Prepare for removing the legacy Unicode C API

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +12363 stage: -> patch review ___ Python tracker ___ ___

[issue36346] Prepare for removing the legacy Unicode C API

New submission from Serhiy Storchaka : The legacy Unicode C API was deprecated in 3.3. Its support consumes resources: more memory usage by Unicode objects, additional code for handling Unicode objects created with the legacy C API. Currently every Unicode object has a cache for the wchar_t