[issue3638] tkinter.mainloop() is meaningless and crash: remove it

Martin v. Löwis added the comment: > But these all would deserve another(s) issues, so I will be moving > "quit" and "dooneevent" from there too. I haven't tried reproducing these problems, but this all sounds plausible. So go ahead and check in all the changes for this issue. Don't forget Mi

[issue3638] tkinter.mainloop() is meaningless and crash: remove it

Guilherme Polo added the comment: > I get an empty string with the text below, but I was expecting some s/text/test ___ Python tracker ___ ___

[issue3638] tkinter.mainloop() is meaningless and crash: remove it

Guilherme Polo added the comment: > These look fine. I think further changes are necessary: > tkinter/__init__.py tries to load createfilehandler/deletefilehandler; > this becomes redundant. Indeed, I forgot to look into the Python code. I also see as redundant the checks for _tkinter._flatten

[issue3638] tkinter.mainloop() is meaningless and crash: remove it

Martin v. Löwis added the comment: These look fine. I think further changes are necessary: tkinter/__init__.py tries to load createfilehandler/deletefilehandler; this becomes redundant. Also, why did you leave DoOneEvent and Quit as-is - don't they fall into the same category? One minor nit: I

[issue3638] tkinter.mainloop() is meaningless and crash: remove it

Changes by Guilherme Polo : Added file: http://bugs.python.org/file12575/deprecated_funcs.diff ___ Python tracker ___ ___ Python-bugs-list mail

[issue3638] tkinter.mainloop() is meaningless and crash: remove it

Guilherme Polo added the comment: Here is a patch, two actually. The next one deprecates the functions in trunk Added file: http://bugs.python.org/file12574/issue3638.diff ___ Python tracker ___

[issue3638] tkinter.mainloop() is meaningless and crash: remove it

Martin v. Löwis added the comment: > This is all true but the dispatching isn't used there actually. > dispatching is being used in a polling manner to try to catch the > thread running the tcl interpreter which someone tried to call into, > the code then proceeds to do what you described. Righ

[issue3638] tkinter.mainloop() is meaningless and crash: remove it

Guilherme Polo added the comment: > Martin v. Löwis added the comment: > >> But I don't see a RPC being used there, I just see some polling. > > Consider Tkapp_Call (e.g.). If this is invoked in the Tk interpreter > thread, then there is a direct call to Tcl_EvalObjv/Tkapp_CallResult. > > If th

[issue3638] tkinter.mainloop() is meaningless and crash: remove it

Martin v. Löwis added the comment: > But I don't see a RPC being used there, I just see some polling. Consider Tkapp_Call (e.g.). If this is invoked in the Tk interpreter thread, then there is a direct call to Tcl_EvalObjv/Tkapp_CallResult. If the call is made from a different thread, then a T

[issue3638] tkinter.mainloop() is meaningless and crash: remove it

Guilherme Polo added the comment: > Martin v. Löwis added the comment: > >> Now, I'm much more in favour to remove it from moduleMethods than from >> adjusting it to work in py3k. > > Would you apply the same reasoning to the other Tkapp methods available > on _tkinter? > As I see all those fu

[issue3638] tkinter.mainloop() is meaningless and crash: remove it

STINNER Victor added the comment: > Victor, you seem to be confusing "code that supports it" with "functions > that use it" Oh ok, I didn't understood what "code that supports it" mean. > There are some conditional code inside Tkapp_MainLoop that > depends on self being available, that is wha

[issue3638] tkinter.mainloop() is meaningless and crash: remove it

Martin v. Löwis added the comment: > Now, I'm much more in favour to remove it from moduleMethods than from > adjusting it to work in py3k. Would you apply the same reasoning to the other Tkapp methods available on _tkinter? IIRC, these functions were there first; the Tkapp object was added la

[issue3638] tkinter.mainloop() is meaningless and crash: remove it

Guilherme Polo added the comment: Victor, you seem to be confusing "code that supports it" with "functions that use it". There are some conditional code inside Tkapp_MainLoop that depends on self being available, that is what Martin meant by code that supports it, and since it would no longer be

[issue3638] tkinter.mainloop() is meaningless and crash: remove it

Martin v. Löwis added the comment: > Ok. In Python 2.x, selfptr is NULL whereas selfptr is a pointer to the > module in Python 3.x. New attached patch uses PyModule_Check() to > check if selfptr is the module or an object. The patch looks right in principle. Please make sure not to include pr

[issue3638] tkinter.mainloop() is meaningless and crash: remove it

STINNER Victor added the comment: > Tkapp_Mainloop is supposed to work both as a module function > and a method, and it tests for self to find out which > case it is. Now, this test is apparently broken in 3.x, ... Ok. In Python 2.x, selfptr is NULL whereas selfptr is a pointer to the module

[issue3638] tkinter.mainloop() is meaningless and crash: remove it

Changes by STINNER Victor : Removed file: http://bugs.python.org/file11200/tkinter_remove_mainloop.patch ___ Python tracker ___ ___ Python-bugs

[issue3638] tkinter.mainloop() is meaningless and crash: remove it

Martin v. Löwis added the comment: The patch is incorrect. Tkapp_Mainloop is supposed to work both as a module function and a method, and it tests for self to find out which case it is. Now, this test is apparently broken in 3.x, but that could be fixed, instead of ripping the module function ou

[issue3638] tkinter.mainloop() is meaningless and crash: remove it

Antoine Pitrou added the comment: Well, well, sorry for the noise! ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue3638] tkinter.mainloop() is meaningless and crash: remove it

Guilherme Polo added the comment: On Wed, Dec 31, 2008 at 2:27 PM, Guilherme Polo wrote: > > Guilherme Polo added the comment: > > On Wed, Dec 31, 2008 at 2:24 PM, Antoine Pitrou > wrote: >> >> Antoine Pitrou added the comment: >> >> "tkinter.mainloop" seems used in a bunch of places accord

[issue3638] tkinter.mainloop() is meaningless and crash: remove it

Guilherme Polo added the comment: On Wed, Dec 31, 2008 at 2:24 PM, Antoine Pitrou wrote: > > Antoine Pitrou added the comment: > > "tkinter.mainloop" seems used in a bunch of places according to Google > Code. Am I missing something? > Yes, those are not _tkinter.mainlooop, they are Tkinter.m

[issue3638] tkinter.mainloop() is meaningless and crash: remove it

Antoine Pitrou added the comment: "tkinter.mainloop" seems used in a bunch of places according to Google Code. Am I missing something? http://www.google.com/codesearch?hl=fr&lr=&q=%22tkinter.mainloop%22&sbtn=Rechercher -- nosy: +pitrou ___ Python tr

[issue3638] tkinter.mainloop() is meaningless and crash: remove it

STINNER Victor added the comment: gpolo agree to remove it. If no one is opposed for this change, can someone apply the patch? ___ Python tracker ___

[issue3638] tkinter.mainloop() is meaningless and crash: remove it

Changes by Guilherme Polo <[EMAIL PROTECTED]>: -- title: tkinter.mainloop() is meanling less and crash: remove it -> tkinter.mainloop() is meaningless and crash: remove it ___ Python tracker <[EMAIL PROTECTED]>