[issue36405] Use dict unpacking in idlelib

Terry J. Reedy added the comment: Immediate followup is #30348, add autocomplete tests. At least one would have failed with the initial patch. -- ___ Python tracker ___

[issue36405] Use dict unpacking in idlelib

Change by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue36405] Use dict unpacking in idlelib

miss-islington added the comment: New changeset 2b580146a53311e4202b0be63040740cdc01f1f5 by Miss Islington (bot) in branch '3.7': bpo-36405: IDLE - Restore __main__ and add tests (GH-12518) https://github.com/python/cpython/commit/2b580146a53311e4202b0be63040740cdc01f1f5 -- ___

[issue36405] Use dict unpacking in idlelib

Terry J. Reedy added the comment: New changeset 0fe4513d9a5510ae91c0da7eb0433f79a6d4dda9 by Terry Jan Reedy in branch 'master': bpo-36405: IDLE - Restore __main__ and add tests (#12518) https://github.com/python/cpython/commit/0fe4513d9a5510ae91c0da7eb0433f79a6d4dda9 -- ___

[issue36405] Use dict unpacking in idlelib

Change by miss-islington : -- pull_requests: +12477 stage: commit review -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue36405] Use dict unpacking in idlelib

Terry J. Reedy added the comment: Also, __builtins__ is only a module, with a __dict__, in __main__. -- stage: patch review -> commit review ___ Python tracker ___ ___

[issue36405] Use dict unpacking in idlelib

Change by Terry J. Reedy : -- pull_requests: +12469 stage: commit review -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue36405] Use dict unpacking in idlelib

Terry J. Reedy added the comment: You mean that the patch will execute the code in imported module where the two are not even equal. So I will revert the '__main__' changes. I found two differences in completion behavior with the patch. One is a failure that should work, another is a succe

[issue36405] Use dict unpacking in idlelib

miss-islington added the comment: New changeset 00986ec5530f004fca2c2675a822c73f06283bdf by Miss Islington (bot) in branch '3.7': bpo-36405: Use dict unpacking in idlelib (GH-12507) https://github.com/python/cpython/commit/00986ec5530f004fca2c2675a822c73f06283bdf -- nosy: +miss-isli

[issue36405] Use dict unpacking in idlelib

Serhiy Storchaka added the comment: It is true only in the main script or REPL. But you executed that code in imported modules. -- ___ Python tracker ___

[issue36405] Use dict unpacking in idlelib

Terry J. Reedy added the comment: I hit merge before seeing your post here. I based the globals change on >>> import __main__ >>> __main__.__dict__ is globals() True -- ___ Python tracker _

[issue36405] Use dict unpacking in idlelib

Change by miss-islington : -- pull_requests: +12461 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue36405] Use dict unpacking in idlelib

Terry J. Reedy added the comment: New changeset 2b75155590eb42d25e474b776ee9fdcc4b3dc840 by Terry Jan Reedy in branch 'master': bpo-36405: Use dict unpacking in idlelib (#12507) https://github.com/python/cpython/commit/2b75155590eb42d25e474b776ee9fdcc4b3dc840 -- ___

[issue36405] Use dict unpacking in idlelib

Serhiy Storchaka added the comment: It is not unnecessary. globals() is not the same as __main__.__dict__. It may be possible to use a ChainMap instead of merging dicts, but I do not think it matters. -- nosy: +serhiy.storchaka ___ Python tracker

[issue36405] Use dict unpacking in idlelib

Change by Terry J. Reedy : -- keywords: +patch pull_requests: +12458 stage: commit review -> patch review ___ Python tracker ___ ___

[issue36405] Use dict unpacking in idlelib

New submission from Terry J. Reedy : Replace 3 occurrences of 'd = d1.copy(); d.update(d2)' pattern with 'd = {**d1, **d2}'. Also remove unnecessary imports and uses of __main__. -- assignee: terry.reedy components: IDLE messages: 338643 nosy: terry.reedy priority: normal severity: no