[issue36564] Infinite loop with short maximum line lengths in EmailPolicy

Change by Ned Deily : -- keywords: +security_issue resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.6, Python 3.9 ___ Python tracker

[issue36564] Infinite loop with short maximum line lengths in EmailPolicy

Ned Deily added the comment: New changeset 79a47e2b9cff6c9facdbc022a752177ab89dc533 by Ned Deily (Miss Islington (bot)) in branch '3.6': Fix infinite loop in email folding logic (GH-12732) (GH-14799) https://github.com/python/cpython/commit/79a47e2b9cff6c9facdbc022a752177ab89dc533

[issue36564] Infinite loop with short maximum line lengths in EmailPolicy

miss-islington added the comment: New changeset e7bec26937ce602ca21cc1f78a391adcf5eafdf1 by Miss Islington (bot) in branch '3.7': Fix infinite loop in email folding logic (GH-12732) https://github.com/python/cpython/commit/e7bec26937ce602ca21cc1f78a391adcf5eafdf1 --

[issue36564] Infinite loop with short maximum line lengths in EmailPolicy

miss-islington added the comment: New changeset 6a2aec0ff587032beb8aac8cbebb09e7a52f6694 by Miss Islington (bot) in branch '3.8': Fix infinite loop in email folding logic (GH-12732) https://github.com/python/cpython/commit/6a2aec0ff587032beb8aac8cbebb09e7a52f6694 -- nosy:

[issue36564] Infinite loop with short maximum line lengths in EmailPolicy

Change by miss-islington : -- pull_requests: +14595 pull_request: https://github.com/python/cpython/pull/14799 ___ Python tracker ___

[issue36564] Infinite loop with short maximum line lengths in EmailPolicy

Barry A. Warsaw added the comment: New changeset f69d5c61981ea97d251db515c7ff280fcc17182d by Barry Warsaw (Paul Ganssle) in branch 'master': Fix infinite loop in email folding logic (GH-12732) https://github.com/python/cpython/commit/f69d5c61981ea97d251db515c7ff280fcc17182d --

[issue36564] Infinite loop with short maximum line lengths in EmailPolicy

Change by miss-islington : -- pull_requests: +14594 pull_request: https://github.com/python/cpython/pull/14798 ___ Python tracker ___

[issue36564] Infinite loop with short maximum line lengths in EmailPolicy

Change by miss-islington : -- pull_requests: +14593 pull_request: https://github.com/python/cpython/pull/14797 ___ Python tracker ___

[issue36564] Infinite loop with short maximum line lengths in EmailPolicy

R. David Murray added the comment: Right, one of the fundamental principles of the email library is that when parsing input we do not ever raise an error. We may note defects, but whatever we get we *must* parse and turn in to *something*. --

[issue36564] Infinite loop with short maximum line lengths in EmailPolicy

Abhilash Raj added the comment: I was wrong about the parsing error, it looks like length from the policy isn't used when parsing. >>> from email.policy import default >>> from email import message_from_string >>> p = default.clone(max_line_length=10) >>> msg = message_from_string("""\ ...

[issue36564] Infinite loop with short maximum line lengths in EmailPolicy

R. David Murray added the comment: Good point about the backward compatibility. Yes I agree, I think raising the error is probably better. A deprecation warning seems like a good path forward...I will be very surprised if anyone encounters it, though :) --

[issue36564] Infinite loop with short maximum line lengths in EmailPolicy

Paul Ganssle added the comment: Responding to a comment on the PR: > Now, that said you might want to consider the fact that in > _fold_mime_parameters I deal with this issue by bumping maxlen to 78 rather > than raising an error. I'm not sure that was the right choice, but whatever > we

[issue36564] Infinite loop with short maximum line lengths in EmailPolicy

R. David Murray added the comment: As for the other, I don't see the need for a custom error. It's a ValueError in my view. I wouldn't object to it strongly, but note that this error is content dependent. If there's nothing to encode, you can "get away with" a shorter maxlen. Though why

[issue36564] Infinite loop with short maximum line lengths in EmailPolicy

R. David Murray added the comment: Can you demonstrate the parsing error? maxlen should have no effect during parsing. -- ___ Python tracker ___

[issue36564] Infinite loop with short maximum line lengths in EmailPolicy

Abhilash Raj added the comment: Moving the conversation here from https://github.com/python/cpython/pull/12732 for David. I previously suggested HeaderParseError because of the fact that we could fail to parse a value into a Header Object in the above scenario. @r.david.murray Would it be

[issue36564] Infinite loop with short maximum line lengths in EmailPolicy

Change by Paul Ganssle : -- nosy: +maxking, msapiro ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36564] Infinite loop with short maximum line lengths in EmailPolicy

Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36564] Infinite loop with short maximum line lengths in EmailPolicy

Change by Paul Ganssle : -- keywords: +patch pull_requests: +12655 stage: -> patch review ___ Python tracker ___ ___

[issue36564] Infinite loop with short maximum line lengths in EmailPolicy

New submission from Paul Ganssle : When reviewing PR 12020 fixing an infinite loop in the e-mail module, I noticed that a *different* infinite loop is documented with a "# XXX" comment on line 2724: