[issue36571] Lib/smtplib.py have some pep8 issues

2019-04-09 Thread Marcin Niemira
Marcin Niemira added the comment: Thanks for the explanation. I'll close issue and PR. Cheers :) -- stage: patch review -> resolved status: open -> closed ___ Python tracker _

[issue36571] Lib/smtplib.py have some pep8 issues

2019-04-09 Thread Christian Heimes
Christian Heimes added the comment: Yes, I totally agree with xtreak. We try to avoid unnecessary code changes. Any change comes with a risk and cost to pay. PEP 8 is just a guideline for new code. -- nosy: +christian.heimes ___ Python tracker

[issue36571] Lib/smtplib.py have some pep8 issues

2019-04-09 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Generally changes only related to PEP 8 are not merged since they pollute git history while using blame and a lot of other modules also don't adhere to PEP 8. New code written can have PEP 8 enforced or the related parts of the code can be refactor

[issue36571] Lib/smtplib.py have some pep8 issues

2019-04-09 Thread Marcin Niemira
New submission from Marcin Niemira : pycodestyle (pep8) reports some issues on linting for Lib/smtplib.py I believe we can fix most of them and apply some improvements due to pep-572. PR on GH. Are contributions like this valuable? -- components: Library (Lib) messages: 339714 nosy:

[issue36571] Lib/smtplib.py have some pep8 issues

2019-04-09 Thread Marcin Niemira
Change by Marcin Niemira : -- keywords: +patch pull_requests: +12664 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-