[issue3663] Extra DECREF on syntax errors

2008-08-26 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Committed in r66041. Thanks everyone. -- resolution: accepted -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> _

[issue3663] Extra DECREF on syntax errors

2008-08-26 Thread Barry A. Warsaw
Barry A. Warsaw <[EMAIL PROTECTED]> added the comment: Benjamin's reviewed it, so please commit it. Is there a test for this crasher? -- nosy: +barry resolution: -> accepted ___ Python tracker <[EMAIL PROTECTED]> _

[issue3663] Extra DECREF on syntax errors

2008-08-26 Thread Barry A. Warsaw
Changes by Barry A. Warsaw <[EMAIL PROTECTED]>: -- priority: deferred blocker -> release blocker ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3663] Extra DECREF on syntax errors

2008-08-25 Thread Benjamin Peterson
Benjamin Peterson <[EMAIL PROTECTED]> added the comment: The patch looks fine to me. -- nosy: +benjamin.peterson ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3663] Extra DECREF on syntax errors

2008-08-25 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: Agreed. PyErr_ExceptionMatches returns owned references, so the tb variable has to remain an owned reference. Patch attached, please review. -- keywords: +needs review, patch Added file: http://bugs.python.org/file11242/missing-

[issue3663] Extra DECREF on syntax errors

2008-08-24 Thread Georg Brandl
Georg Brandl <[EMAIL PROTECTED]> added the comment: The culprit is Python/pythonrun.c:1245: tb = tb ? tb : Py_None; Py_None needs to be INCREF'd in the else case. -- assignee: -> pitrou nosy: +georg.brandl ___ Python tracker <[EMAIL PROTECTED]>

[issue3663] Extra DECREF on syntax errors

2008-08-24 Thread Antoine Pitrou
Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- nosy: +pitrou ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mailing

[issue3663] Extra DECREF on syntax errors

2008-08-24 Thread Amaury Forgeot d'Arc
New submission from Amaury Forgeot d'Arc <[EMAIL PROTECTED]>: The following output is very suspect: the total number of references decreases! Python 3.0b3+ (py3k, Aug 24 2008, 21:56:40) [MSC v.1500 32 bit (Intel)] on win32 Type "help", "copyright", "credits" or "license" for more information. >>