[issue3668] "s*" argument parser marker leaks memory

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Committed in r66057 and r66058. -- resolution: accepted -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3668] "s*" argument parser marker leaks memory

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: Yes, let them go in! -- resolution: -> accepted ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3668] "s*" argument parser marker leaks memory

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Amaury, are these patches ok to check in? ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Py

[issue3668] "s*" argument parser marker leaks memory

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: And a similarly better patch for 2.6. -- versions: +Python 2.6 Added file: http://bugs.python.org/file11248/argleak2-2.6.patch ___ Python tracker <[EMAIL PROTECTED]>

[issue3668] "s*" argument parser marker leaks memory

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Actually, here is a better patch for py3k. Added file: http://bugs.python.org/file11246/argleak3.patch ___ Python tracker <[EMAIL PROTECTED]>

[issue3668] "s*" argument parser marker leaks memory

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: Both patches look good to me. ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-b

[issue3668] "s*" argument parser marker leaks memory

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Here is a patch for 2.6. Added file: http://bugs.python.org/file11245/argleak-2.6.patch ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3668] "s*" argument parser marker leaks memory

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: By the way, this bug affects 2.6 as well, although not in binascii since it has not been converted to use "s*": >>> codecs.latin_1_decode(b"", 0) Traceback (most recent call last): File "", line 1, in TypeError: latin_1_decode() argument 2

[issue3668] "s*" argument parser marker leaks memory

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Ok, here is a new patch addressing Amaury's comments. Added file: http://bugs.python.org/file11244/argleak2.patch ___ Python tracker <[EMAIL PROTECTED]> _

[issue3668] "s*" argument parser marker leaks memory

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: This patch elegantly reuses the existing cleanup list. Only two remarks: - there are a few tabs/spaces inconsistencies. - I would make the cleanup_ptr explicit: intead of addcleanup(*buffer, freelist, NULL); I'd prefer add

[issue3668] "s*" argument parser marker leaks memory

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Here is a patch. Please review. -- keywords: +needs review, patch type: -> resource usage Added file: http://bugs.python.org/file11243/argleak.patch ___ Python tracker <[EMAIL PROTECTED]>

[issue3668] "s*" argument parser marker leaks memory

Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- assignee: -> pitrou ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list m

[issue3668] "s*" argument parser marker leaks memory

Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- nosy: +pitrou ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mailing

[issue3668] "s*" argument parser marker leaks memory

New submission from Amaury Forgeot d'Arc <[EMAIL PROTECTED]>: When PyArg_ParseTuple correctly parses a s* format, but raises an exception afterwards (for a subsequent parameter), the user code will not call PyBuffer_Release() and memory will leak. Seen by "regrtest -R:: test_binascii" For exampl