[issue36865] FileInput does not allow 'rt' mode, but all its existing delegates do

Inada Naoki added the comment: I don't think we should support "text for regular file but binary for compressed file" mode in FileInput. So no need to add 't'. We should just fix #5758. -- nosy: +methane resolution: -> duplicate stage: patch review -> resolved status: open -> closed

[issue36865] FileInput does not allow 'rt' mode, but all its existing delegates do

Nathaniel Gaertner added the comment: Hey sorry for the delay in responding. My thought with forcing 'rt' mode is that it would actually reduce the flexibility of the FileInput class. For 5758, I suspect the issue arose out of a confusion about what strings meant in python 2 vs 3. If I under

[issue36865] FileInput does not allow 'rt' mode, but all its existing delegates do

Berker Peksag added the comment: Thank you for the report and the PR! I think accepting 'rt' mode is a good idea. However, it's a new feature and it can only go into 3.8. It seems to me that the root cause of the issue is that the fileinput module wasn't properly converted to support Python

[issue36865] FileInput does not allow 'rt' mode, but all its existing delegates do

Change by SilentGhost : -- nosy: +berker.peksag versions: -Python 3.5, Python 3.6, Python 3.7 ___ Python tracker ___ ___ Python-bug

[issue36865] FileInput does not allow 'rt' mode, but all its existing delegates do

Change by Nathaniel Gaertner : -- keywords: +patch pull_requests: +13131 stage: -> patch review ___ Python tracker ___ ___ Python-b

[issue36865] FileInput does not allow 'rt' mode, but all its existing delegates do

New submission from Nathaniel Gaertner : While looking at https://bugs.python.org/issue5758 I noticed that 'rt' support had been added to gzip and bz2 in 3.3, but FileInput still limited its mode options to 'r', 'rb', 'rU', and 'U'. It seems like 'rt' should be just fine here as well, and wou