[issue36876] Global C variables are a problem.

Change by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36876] Global C variables are a problem.

Eric Snow added the comment: And I *am* still working on the c-analyzer + a test to that runs it, so we can keep from adding more globals. :) -- ___ Python tracker ___

[issue36876] Global C variables are a problem.

Eric Snow added the comment: FYI, others have been tackling this in separate issues (e.g. Victor, anyone relative to PEP 384). -- ___ Python tracker ___

[issue36876] Global C variables are a problem.

Eric Snow added the comment: Thanks, Vinay! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36876] Global C variables are a problem.

Change by Chih-Hsuan Yen : -- nosy: -yan12125 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36876] Global C variables are a problem.

Vinay Sajip added the comment: New changeset 9def81aa52adc3cc89554156e40742cf17312825 by Vinay Sajip in branch 'master': bpo-36876: Moved Parser/listnode.c statics to interpreter state. (GH-16328) https://github.com/python/cpython/commit/9def81aa52adc3cc89554156e40742cf17312825 --

[issue36876] Global C variables are a problem.

Eric Snow added the comment: New changeset e4c431ecf50def40eb93c3969c1e4eeaf7bf32f1 by Eric Snow in branch 'master': bpo-36876: Re-organize the c-analyzer tool code. (gh-16841) https://github.com/python/cpython/commit/e4c431ecf50def40eb93c3969c1e4eeaf7bf32f1 --

[issue36876] Global C variables are a problem.

Change by Eric Snow : -- pull_requests: +16393 pull_request: https://github.com/python/cpython/pull/16841 ___ Python tracker ___

[issue36876] Global C variables are a problem.

Change by Vinay Sajip : -- pull_requests: +15904 pull_request: https://github.com/python/cpython/pull/16328 ___ Python tracker ___

[issue36876] Global C variables are a problem.

Change by Vinay Sajip : -- nosy: +vinay.sajip ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36876] Global C variables are a problem.

Eric Snow added the comment: New changeset 088b63ea7a8331a3e34bc93c3b873c60354b4fad by Eric Snow in branch 'master': bpo-36876: Fix the globals checker tool. (gh-16058) https://github.com/python/cpython/commit/088b63ea7a8331a3e34bc93c3b873c60354b4fad --

[issue36876] Global C variables are a problem.

Change by Eric Snow : -- pull_requests: +15681 pull_request: https://github.com/python/cpython/pull/16058 ___ Python tracker ___

[issue36876] Global C variables are a problem.

Eric Snow added the comment: New changeset 64535fc6c0712caef0bc46be30e661f7ccf8280e by Eric Snow in branch 'master': bpo-36876: Skip test_check_c_globals for now. (gh-16017) https://github.com/python/cpython/commit/64535fc6c0712caef0bc46be30e661f7ccf8280e --

[issue36876] Global C variables are a problem.

Change by Eric Snow : -- pull_requests: +15640 pull_request: https://github.com/python/cpython/pull/16017 ___ Python tracker ___

[issue36876] Global C variables are a problem.

Eric Snow added the comment: @db3l, I'll take a look right away. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue36876] Global C variables are a problem.

Change by Chih-Hsuan Yen : -- nosy: +yan12125 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36876] Global C variables are a problem.

David Bolen added the comment: The new test_check_c_globals.ActualChecks test is failing with an "unexpected success" on the bolen-ubuntu buildbot (under Ubuntu 18.04.3). I can reproduce the failure in a manually built tree. -- nosy: +db3l ___

[issue36876] Global C variables are a problem.

Eric Snow added the comment: New changeset ee536b2020b1f0baad1286dbd4345e13870324af by Eric Snow in branch 'master': bpo-36876: Add a tool that identifies unsupported global C variables. (#15877) https://github.com/python/cpython/commit/ee536b2020b1f0baad1286dbd4345e13870324af --

[issue36876] Global C variables are a problem.

Change by Eric Snow : -- pull_requests: +15518 pull_request: https://github.com/python/cpython/pull/15877 ___ Python tracker ___

[issue36876] Global C variables are a problem.

Change by Eric Snow : -- pull_requests: +15413 pull_request: https://github.com/python/cpython/pull/15760 ___ Python tracker ___

[issue36876] Global C variables are a problem.

Change by Paulo Henrique Silva : -- nosy: +phsilva ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36876] Global C variables are a problem.

Change by Eric Snow : -- pull_requests: +13445 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36876] Global C variables are a problem.

Change by Eric Snow : -- keywords: +patch pull_requests: +13283 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue36876] Global C variables are a problem.

Change by Christian Heimes : -- nosy: +christian.heimes ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36876] Global C variables are a problem.

Change by Pablo Galindo Salgado : -- nosy: +pablogsal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36876] Global C variables are a problem.

Eric Snow added the comment: Also, Tools/c-globals/ignored-globals.txt is a bit out of date (some vars have been removed, renamed, or moved to another file). That should get cleaned up. It might also make sense to update check-c-globals.py to verify that all variables in

[issue36876] Global C variables are a problem.

New submission from Eric Snow : We still have a bunch of "global" C variables (static globals, static locals, maybe thread-local storage) in our code-base that break the isolation between interpreters. I added Tools/c-globals/check-c-globals.py a while back to help identify such variables,