[issue36959] ISO date errors in _strptime are jumbled

Gordon P. Hemsley added the comment: Ah yes, to be clear, I wasn't trying to suggest that the error messages themselves were wrong—just that they weren't triggering when the tests were expecting them to. Some of the existing tests currently trigger the "unconverted data remains" ValueError f

[issue36959] ISO date errors in _strptime are jumbled

Paul Ganssle added the comment: Hm, I was a bit confused by your wording here, because I am able to trigger all the errors just fine even before this PR, but I do think that even though this isn't necessarily fixing inaccurate error messages (all the error messages *are* accurate), you're ri

[issue36959] ISO date errors in _strptime are jumbled

Gordon P. Hemsley added the comment: I've created a PR that fixes the issue, which I discovered while evaluating the test coverage for _strptime. Certain scenarios of error messages were never being hit because the cascade was out of order, and the tests were not showing that because they we

[issue36959] ISO date errors in _strptime are jumbled

Change by Gordon P. Hemsley : -- keywords: +patch pull_requests: +13319 stage: -> patch review ___ Python tracker ___ ___ Python-bu

[issue36959] ISO date errors in _strptime are jumbled

Paul Ganssle added the comment: @gphelmsley Can you clarify what you mean by this? Do you have a minimal reproducing example that shows what's happening and what you are expecting? -- ___ Python tracker __

[issue36959] ISO date errors in _strptime are jumbled

Change by Karthikeyan Singaravelan : -- nosy: +p-ganssle ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue36959] ISO date errors in _strptime are jumbled

New submission from Gordon P. Hemsley : This has not been apparent because the tests for this code are not testing what they think they're testing. -- components: Library (Lib), Tests messages: 342810 nosy: gphemsley priority: normal severity: normal status: open title: ISO date errors