[issue37072] PyNode_Compile() crashes in Python 3.8.

Change by Guido van Rossum : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue37072] PyNode_Compile() crashes in Python 3.8.

Guido van Rossum added the comment: New changeset 77f0ed7a42606d03ebfe48ab152caf0d796d6540 by Guido van Rossum in branch 'master': bpo-37072: Fix crash in PyAST_FromNodeObject() when flags is NULL (#13634) https://github.com/python/cpython/commit/77f0ed7a42606d03ebfe48ab152caf0d796d6540 ---

[issue37072] PyNode_Compile() crashes in Python 3.8.

Change by Guido van Rossum : -- keywords: +patch pull_requests: +13534 stage: -> patch review pull_request: https://github.com/python/cpython/pull/13634 ___ Python tracker ___

[issue37072] PyNode_Compile() crashes in Python 3.8.

Guido van Rossum added the comment: OK, I'll look into this. -- assignee: -> gvanrossum nosy: +gvanrossum ___ Python tracker ___ _

[issue37072] PyNode_Compile() crashes in Python 3.8.

STINNER Victor added the comment: I mark this issue as a release blocker. -- nosy: +lukasz.langa, vstinner priority: normal -> release blocker ___ Python tracker ___ _

[issue37072] PyNode_Compile() crashes in Python 3.8.

Petr Viktorin added the comment: Looks like this is caused by: https://github.com/python/cpython/pull/12086/files#diff-4d35cf8992b795c5e97e9c8b6167cb34R787 PyAST_FromNodeObject doesn't ignore flags any more, so when PyNode_Compile passes NULL flags, it crashes. (This is unfamiliar code for

[issue37072] PyNode_Compile() crashes in Python 3.8.

Graham Dumpleton added the comment: FWIW, this was occurring on macOS. Not been able to test on other platforms. -- type: -> crash ___ Python tracker ___

[issue37072] PyNode_Compile() crashes in Python 3.8.

New submission from Graham Dumpleton : The code: #include int main(int argc, char *argv[]) { FILE *fp = NULL; PyObject *co = NULL; struct _node *n = NULL; const char * filename = "/dev/null"; Py_Initialize(); fprintf(stderr, "START\n"); fp = fopen(filename, "r")