[issue3709] BaseHTTPRequestHandler innefficient when sending HTTP header

Terry J. Reedy added the comment: Does this issue apply to 3.1/2? -- nosy: +tjreedy versions: +Python 2.7 -Python 2.5 ___ Python tracker ___ _

[issue3709] BaseHTTPRequestHandler innefficient when sending HTTP header

Senthil Kumaran added the comment: Yes, it is applicable to 3.1 and 3.2 as well. This is definitely a good to have performance improvement. -- nosy: +orsenthil versions: +Python 3.1, Python 3.2 ___ Python tracker

[issue3709] BaseHTTPRequestHandler innefficient when sending HTTP header

Roundup Robot added the comment: New changeset 25298224cb25 by Senthil Kumaran in branch 'default': Issue #3709: a flush_headers method to BaseHTTPRequestHandler which manages the http://hg.python.org/cpython/rev/25298224cb25 -- nosy: +python-dev ___

[issue3709] BaseHTTPRequestHandler innefficient when sending HTTP header

Senthil Kumaran added the comment: Added the flush_headers method and the test function. this issue can be closed now. Thanks, Andrew Schaaf. -- status: open -> closed ___ Python tracker __

[issue3709] BaseHTTPRequestHandler innefficient when sending HTTP header

Changes by Arfrever Frehtes Taifersar Arahesis : -- versions: +Python 3.3 -Python 3.2 ___ Python tracker ___ ___ Python-bugs-list maili

[issue3709] BaseHTTPRequestHandler innefficient when sending HTTP header

endian added the comment: How about this patch? -- keywords: +patch nosy: +endian Added file: http://bugs.python.org/file19689/issue3709.diff ___ Python tracker ___ _

[issue3709] BaseHTTPRequestHandler innefficient when sending HTTP header

Changes by Éric Araujo : -- versions: -Python 2.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue3709] BaseHTTPRequestHandler innefficient when sending HTTP header

R. David Murray added the comment: It looks good, but as mentioned on IRC it would be nice to have a unit test that confirmed that the headers were being correctly buffered. -- nosy: +r.david.murray ___ Python tracker

[issue3709] BaseHTTPRequestHandler innefficient when sending HTTP header

endian added the comment: Working on it... -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue3709] BaseHTTPRequestHandler innefficient when sending HTTP header

Changes by endian : Added file: http://bugs.python.org/file19692/issue3709.diff ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue3709] BaseHTTPRequestHandler innefficient when sending HTTP header

endian added the comment: Ready for review. Added test_header_buffering which fails without the BaseHTTPRequestHandler patch and passes with it. -- Added file: http://bugs.python.org/file19704/issue3709.diff ___ Python tracker

[issue3709] BaseHTTPRequestHandler innefficient when sending HTTP header

Changes by endian : Removed file: http://bugs.python.org/file19689/issue3709.diff ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue3709] BaseHTTPRequestHandler innefficient when sending HTTP header

Changes by endian : Removed file: http://bugs.python.org/file19692/issue3709.diff ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue3709] BaseHTTPRequestHandler innefficient when sending HTTP header

Bruno Gola added the comment: applied the patch on py3k on trunk and everything seems fine (works here) -- nosy: +brunogola ___ Python tracker ___ ___

[issue3709] BaseHTTPRequestHandler innefficient when sending HTTP header

R. David Murray added the comment: Thanks for the patch and test. They look good. A doc update is also needed, since the docs are currently written in such a way that buffering the header lines makes the documentation no longer true. Also, send_response_only writes directly to the output str

[issue3709] BaseHTTPRequestHandler innefficient when sending HTTP header

Changes by R. David Murray : -- stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue3709] BaseHTTPRequestHandler innefficient when sending HTTP header

Senthil Kumaran added the comment: Fixed this revision 86640. - Even though this is an internal optimization,I don't think back-porting is a good idea, because it changes the behavior of certain methods like send_header and end_headers - Added the Documentation and other test scenario which

[issue3709] BaseHTTPRequestHandler innefficient when sending HTTP header

R. David Murray added the comment: Senthil, I didn't clearly express my concern about send_response_only. It doesn't look to me like, with buffering in place, that it *should* write directly, it looks to me like it should write to the buffer. Consider specifically the fact that send_respons

[issue3709] BaseHTTPRequestHandler innefficient when sending HTTP header

Senthil Kumaran added the comment: On Sun, Nov 21, 2010 at 03:15:06PM +, R. David Murray wrote: > Senthil, I didn't clearly express my concern about > send_response_only. It doesn't look to me like, with buffering in > place, that it *should* write directly, it looks to me like it > should

[issue3709] BaseHTTPRequestHandler innefficient when sending HTTP header

Andrew Schaaf added the comment: This patch (to 86665)... * adds buffering to send_response_only * adds flush_headers and uses it in end_headers and CGIHTTPRequestHandler.run_cgi * tests {send_error,send_response_only,send_header} using a write-counting wfile * improves the docs Also, I've add

[issue3709] BaseHTTPRequestHandler innefficient when sending HTTP header

New submission from Yang Zhao <[EMAIL PROTECTED]>: send_header() in BaseHTTPRequestHandler currently does a write to socket every time send_header() is called. This results in excessive number of TCP packets being regenerated. Ideally, as much of the HTTP packet is buffered as possible, but, at m

[issue3709] BaseHTTPRequestHandler innefficient when sending HTTP header

Gregory P. Smith <[EMAIL PROTECTED]> added the comment: Buffering up header IO and sending it all at once is always a good thing to do. A patch and unit test would be greatly appreciated. -- assignee: -> gregory.p.smith nosy: +gregory.p.smith priority: -> normal versions: +Python 2.6