[issue37104] logging.Logger.disabled is not documented

2019-05-31 Thread Mario Corchero
Mario Corchero added the comment: Note that even if not in the standard library I've seen this attributed used and documented quite often. Example: https://docs.python-guide.org/writing/logging/#or-print I would really suggest making it private as mentioned before to make sure this does

[issue37104] logging.Logger.disabled is not documented

2019-05-31 Thread Vinay Sajip
Vinay Sajip added the comment: As it's not documented, people would come across it by browsing the source. I'd just mention in the source (Logger constructor) that it's for internal use, and leave it at that. -- ___ Python tracker

[issue37104] logging.Logger.disabled is not documented

2019-05-31 Thread Mario Corchero
Mario Corchero added the comment: Thanks! I was wondering about it but saw no comment about it, issue or anything in the history. At least we have now this issue :). Would you like that I move this to `_disabled` and have a setter for `disabled` that emits a deprecation warning so we can

[issue37104] logging.Logger.disabled is not documented

2019-05-31 Thread Vinay Sajip
Vinay Sajip added the comment: Thanks for looking at this, Mario, but I'd rather not document this attribute, for the reason stated on the PR when I closed it: "I'd like to avoid documenting this attribute, as it's really meant for internal use by the configuration machinery. I realise that

[issue37104] logging.Logger.disabled is not documented

2019-05-30 Thread Mario Corchero
Change by Mario Corchero : -- keywords: +patch pull_requests: +13575 stage: -> patch review pull_request: https://github.com/python/cpython/pull/13687 ___ Python tracker ___

[issue37104] logging.Logger.disabled is not documented

2019-05-30 Thread Mario Corchero
New submission from Mario Corchero : Just realised the "disabled" attribute of the Logger class is not documented in https://docs.python.org/3/library/logging.html#logging.Logger. Any reason to not have it documented? I'll send a PR otherwise. This comes as I was trying to point to the docs