Benjamin Peterson [EMAIL PROTECTED] added the comment:
I think the patch looks good.
--
nosy: +benjamin.peterson
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3712
___
Changes by Benjamin Peterson [EMAIL PROTECTED]:
--
keywords: -needs review
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3712
___
___
Python-bugs-list
Antoine Pitrou [EMAIL PROTECTED] added the comment:
Fixed in r66111.
--
resolution: - fixed
status: open - closed
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3712
___
New submission from Amaury Forgeot d'Arc [EMAIL PROTECTED]:
Two problems with memoryview:
- The buffer interface of memoryview leaks a reference:
str(memoryview(b'text'), 'utf-8')
- memoryview does not implement tp_traverse and tp_clear, so reference
cycle cannot be collected, as with:
Antoine Pitrou [EMAIL PROTECTED] added the comment:
Here is a patch. I feel a bit unsafe with the intended semantics of
getting a buffer on a memoryview object, but it fixes the leak.
--
components: +Interpreter Core
keywords: +needs review, patch
nosy: +pitrou, teoliphant
type: -
Antoine Pitrou [EMAIL PROTECTED] added the comment:
(I forgot to say, the patch is for the first problem only)
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3712
___
Antoine Pitrou [EMAIL PROTECTED] added the comment:
Here is an aggregate patch addressing both problems. Please review.
Added file: http://bugs.python.org/file11290/memleak2.patch
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3712
