[issue37354] Write PowerShell Activate.ps1 to be static so it can be signed

miss-islington added the comment: New changeset 2b98d8ec7ec3d41c6403ff9f6677a00ea0cb8b92 by Miss Islington (bot) in branch '3.8': bpo-37354: Sign Activate.ps1 for release (GH-15235) https://github.com/python/cpython/commit/2b98d8ec7ec3d41c6403ff9f6677a00ea0cb8b92 -- nosy:

[issue37354] Write PowerShell Activate.ps1 to be static so it can be signed

Steve Dower added the comment: Thanks, Derek! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue37354] Write PowerShell Activate.ps1 to be static so it can be signed

Steve Dower added the comment: New changeset 3e34a25a7a5c9ea2c46f2daeeb60f072faa5aaa1 by Steve Dower in branch 'master': bpo-37354: Sign Activate.ps1 for release (GH-15235) https://github.com/python/cpython/commit/3e34a25a7a5c9ea2c46f2daeeb60f072faa5aaa1 --

[issue37354] Write PowerShell Activate.ps1 to be static so it can be signed

Change by miss-islington : -- pull_requests: +14959 pull_request: https://github.com/python/cpython/pull/15236 ___ Python tracker ___

[issue37354] Write PowerShell Activate.ps1 to be static so it can be signed

Steve Dower added the comment: New changeset 0c64b57e0155c333b7c96ec2af009c1388cd5d31 by Steve Dower (Miss Islington (bot)) in branch '3.8': [3.8] bpo-37354: Make Powershell Activate.ps1 script static to allow for signing (GH-14967)

[issue37354] Write PowerShell Activate.ps1 to be static so it can be signed

Change by Steve Dower : -- pull_requests: +14958 pull_request: https://github.com/python/cpython/pull/15235 ___ Python tracker ___

[issue37354] Write PowerShell Activate.ps1 to be static so it can be signed

Change by miss-islington : -- pull_requests: +14957 pull_request: https://github.com/python/cpython/pull/15233 ___ Python tracker ___

[issue37354] Write PowerShell Activate.ps1 to be static so it can be signed

Steve Dower added the comment: New changeset 732775d6be8062e72cf4995d5a9db0170e22c233 by Steve Dower (Derek Keeler) in branch 'master': bpo-37354: Make Powershell Activate.ps1 script static to allow for signing (GH-14967)

[issue37354] Write PowerShell Activate.ps1 to be static so it can be signed

Steve Dower added the comment: I just chatted with Derek about this, and while we identified some potential regressions (previously we were injecting str(prompt) into Activate.ps1, and now we're showing repr(prompt)), I don't think they're widely used. For example, if you previously did:

[issue37354] Write PowerShell Activate.ps1 to be static so it can be signed

Change by Derek Keeler : -- nosy: +d3r3kk ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37354] Write PowerShell Activate.ps1 to be static so it can be signed

Change by Derek Keeler : -- keywords: +patch pull_requests: +14735 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/14967 ___ Python tracker

[issue37354] Write PowerShell Activate.ps1 to be static so it can be signed

Change by Brett Cannon : -- versions: +Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37354] Write PowerShell Activate.ps1 to be static so it can be signed

Brett Cannon added the comment: > How will this interact with EnvBuilder.install_scripts() (which explicitly > states that it performs textual substitution)? It won't, so that would have to change as well. As you mentioned, Paul, I don't know who even uses the functionality through a

[issue37354] Write PowerShell Activate.ps1 to be static so it can be signed

Steve Dower added the comment: One thing to note is that if we sign this file, it'll have to bypass the text substitution step completely to avoid modifying line endings or encoding. So there could be code changes in venv too. This would be a great contribution from a PowerShell expert, and

[issue37354] Write PowerShell Activate.ps1 to be static so it can be signed

Vinay Sajip added the comment: > It's stored in pyvenv.cfg. Is it? $ python3.8maint -m venv --prompt "foo bar" /tmp/venv $ more /tmp/venv/pyvenv.cfg home = /home/vinay/projects/python/3.8 include-system-site-packages = false version = 3.8.0 prompt = 'foo bar' The source Python location is

[issue37354] Write PowerShell Activate.ps1 to be static so it can be signed

Paul Moore added the comment: How will this interact with EnvBuilder.install_scripts() (which explicitly states that it performs textual substitution)? Note that I'm not aware of anyone who actually uses the ability to subclass EnvBuilder, but I wouldn't be surprised to find that people

[issue37354] Write PowerShell Activate.ps1 to be static so it can be signed

Brett Cannon added the comment: > How would you plan to replace the functionality where the venv's bin path is > substituted into the script? Purely through introspecting its own path? It's stored in pyvenv.cfg. > I presume the security requirements you refer to are purely a Windows >

[issue37354] Write PowerShell Activate.ps1 to be static so it can be signed

Vinay Sajip added the comment: How would you plan to replace the functionality where the venv's bin path is substituted into the script? Purely through introspecting its own path? I see that PowerShell is/will be portable to e.g. Linux environments, but I presume the security requirements

[issue37354] Write PowerShell Activate.ps1 to be static so it can be signed

Change by Caleb Donovick : -- nosy: +donovick ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37354] Write PowerShell Activate.ps1 to be static so it can be signed

New submission from Brett Cannon : If Activate.ps1 was made to not have substitutions upon generation and be an entirely static file, then the file could be signed and thus not require people to lower their security requirements in PowerShell in order to activate their virtual environments.