[issue37405] socket.getsockname() returns string instead of tuple

FRANK BENNETT added the comment: $ make test TESTOPTS="-v test_socket" ERROR: testSendFrame (__main__.CANTest) -- Traceback (most recent call last): File "/s/opt/cpython/debug/test_socket.py", line 2052, in testSendFrame

[issue37405] socket.getsockname() returns string instead of tuple

Brent Gardner added the comment: This test was overlooked, and line 2052 should now be removed per the discussion here: https://github.com/python/cpython/pull/14392#issuecomment-506133908 In short, getsockname() used to return `(interface, socket.AF_CAN)`, in which the socket.AF_CAN element

[issue37405] socket.getsockname() returns string instead of tuple

Change by Brent Gardner : -- pull_requests: +23749 pull_request: https://github.com/python/cpython/pull/24991 ___ Python tracker ___ ___

[issue37405] socket.getsockname() returns string instead of tuple

Change by Brent Gardner : -- type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue37405] socket.getsockname() returns string instead of tuple

New submission from Brent Gardner : In Python 3.5.3, a socket with type AF_CAN returns a tuple in the form `(interface, )` from getsockname(). In Python 3.7.3, getsockname() returns a string (the name of the interface). The documentation states "a tuple is used for the AF_CAN address family

[issue37405] socket.getsockname() returns string instead of tuple

Brent Gardner added the comment: Changed caused by commit effc12f8e9e20d0951d2ba5883587666bd8218e3 to cpython/Modules/socketmodule.c on Sep 6, 2017. -- components: +Extension Modules ___ Python tracker

[issue37405] socket.getsockname() returns string instead of tuple

Brent Gardner added the comment: Correction, change caused by a30f6d45ac3e72761b96a8df0527182029eaee24 to cpython/Modules/socketmodule.c on Aug 28, 2017. -- ___ Python tracker __

[issue37405] socket.getsockname() returns string instead of tuple

Change by Ned Deily : -- nosy: +christian.heimes ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue37405] socket.getsockname() returns string instead of tuple

Change by Roundup Robot : -- keywords: +patch pull_requests: +14206 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14392 ___ Python tracker ___ __

[issue37405] socket.getsockname() returns string instead of tuple

Change by miss-islington : -- pull_requests: +15641 pull_request: https://github.com/python/cpython/pull/16018 ___ Python tracker ___ __

[issue37405] socket.getsockname() returns string instead of tuple

Benjamin Peterson added the comment: New changeset 954900a3f98a8c0dea14dd575490237f3f8626b3 by Benjamin Peterson (bggardner) in branch 'master': closes bpo-37405: Make socket.getsockname() always return a tuple for AF_CAN. (GH-14392) https://github.com/python/cpython/commit/954900a3f98a8c0de

[issue37405] socket.getsockname() returns string instead of tuple

Benjamin Peterson added the comment: New changeset f60fd95dcc189ace8c0a2177a394b9cc20389a1e by Benjamin Peterson (Miss Islington (bot)) in branch '3.8': closes bpo-37405: Make socket.getsockname() always return a tuple for AF_CAN. (GH-14392) (GH-16018) https://github.com/python/cpython/commi