[issue37413] Deprecate sys._enablelegacywindowsfsencoding()

Steve Dower added the comment: I think we can deprecate it but leave it there - the original idea (courtesy of Guido) was to enable apps to transition to the change on their timeline, but it certainly should not be considered a core CPython feature for the rest of time. I don't have a

[issue37413] Deprecate sys._enablelegacywindowsfsencoding()

STINNER Victor added the comment: Oh, INADA-san found an issue of this function: Mercurial. I close this issue and I closed my PR. We can reconsider to deprecate the function once Mercurial will stop to use it. Copy of INADA-san message: """ I think we should keep this several years.

[issue37413] Deprecate sys._enablelegacywindowsfsencoding()

STINNER Victor added the comment: > It's probably worth at least a post to python-dev to expand the audience, but > unless someone speaks up with some really good reason why they must update to > Python 3.10 without updating their own code then let's deprecate it. I don't think that it

[issue37413] Deprecate sys._enablelegacywindowsfsencoding()?

STINNER Victor added the comment: See also draft PEP 597 which proposes to use UTF-8 by default on Windows in Python 3.10: https://www.python.org/dev/peps/pep-0597/ -- ___ Python tracker

[issue37413] Deprecate sys._enablelegacywindowsfsencoding()

Change by STINNER Victor : -- title: Deprecate sys._enablelegacywindowsfsencoding()? -> Deprecate sys._enablelegacywindowsfsencoding() ___ Python tracker ___

[issue37413] Deprecate sys._enablelegacywindowsfsencoding()?

Change by STINNER Victor : -- keywords: +patch pull_requests: +17772 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18396 ___ Python tracker ___

[issue37413] Deprecate sys._enablelegacywindowsfsencoding()?

STINNER Victor added the comment: One of sys._enablelegacywindowsfsencoding() issue is that os.fsdecode() and os.fsencode() are not updated, they continue to use UTF-8. Example on Windows: >>> import sys, os >>> sys.getfilesystemencoding() 'utf-8' >>> os.fsencode('\xe9') b'\xc3\xa9' >>>

[issue37413] Deprecate sys._enablelegacywindowsfsencoding()?

STINNER Victor added the comment: See also bpo-29241. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37413] Deprecate sys._enablelegacywindowsfsencoding()?

Steve Dower added the comment: It's probably worth at least a post to python-dev to expand the audience, but unless someone speaks up with some really good reason why they must update to Python 3.10 without updating their own code then let's deprecate it. FWIW, even with the flag the

[issue37413] Deprecate sys._enablelegacywindowsfsencoding()?

STINNER Victor added the comment: > By the way, I'm not aware of any issue with io._WindowsConsoleIO. Should we > also deprecated PYTHONLEGACYWINDOWSSTDIO environment variable which opt-out > from the new io._WindowsConsoleIO? It was added to Python 3.6 by PEP 528 "Change Windows console

[issue37413] Deprecate sys._enablelegacywindowsfsencoding()?

New submission from STINNER Victor : sys._enablelegacywindowsfsencoding() was added late in PEP 529 design "just in case" if something goes wrong. But I'm not aware of anyone using it. Do we want to keep supporting the *legacy* Windows filesystem encoding (ANSI code page) forever? IMHO using