[issue37478] Docs: Method os.chdir() does not mention errors that can be raised

2019-07-06 Thread Kyle Stanley
Kyle Stanley added the comment: Exceptions for os.chdir() have been added to the docs. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue37478] Docs: Method os.chdir() does not mention errors that can be raised

2019-07-06 Thread miss-islington
miss-islington added the comment: New changeset e414aa9cb002427a39dfd157cdad156336f93ca9 by Miss Islington (bot) in branch '3.8': bpo-37478: Add missing 'and'. (GH-14631) https://github.com/python/cpython/commit/e414aa9cb002427a39dfd157cdad156336f93ca9 --

[issue37478] Docs: Method os.chdir() does not mention errors that can be raised

2019-07-06 Thread miss-islington
miss-islington added the comment: New changeset e841a54206c65770aeb2b936cdc830dd4ed8bf9e by Miss Islington (bot) in branch '3.7': bpo-37478: Add missing 'and'. (GH-14631) https://github.com/python/cpython/commit/e841a54206c65770aeb2b936cdc830dd4ed8bf9e -- nosy: +miss-islington

[issue37478] Docs: Method os.chdir() does not mention errors that can be raised

2019-07-06 Thread miss-islington
Change by miss-islington : -- pull_requests: +14447 pull_request: https://github.com/python/cpython/pull/14633 ___ Python tracker ___

[issue37478] Docs: Method os.chdir() does not mention errors that can be raised

2019-07-06 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset a9b40e4546ca631e5ab41376b5b72e8f296f557d by Terry Jan Reedy in branch 'master': bpo-37478: Add missing 'and'. (GH-14631) https://github.com/python/cpython/commit/a9b40e4546ca631e5ab41376b5b72e8f296f557d --

[issue37478] Docs: Method os.chdir() does not mention errors that can be raised

2019-07-06 Thread miss-islington
Change by miss-islington : -- pull_requests: +14446 pull_request: https://github.com/python/cpython/pull/14632 ___ Python tracker ___

[issue37478] Docs: Method os.chdir() does not mention errors that can be raised

2019-07-06 Thread Terry J. Reedy
Change by Terry J. Reedy : -- pull_requests: +14445 pull_request: https://github.com/python/cpython/pull/14631 ___ Python tracker ___

[issue37478] Docs: Method os.chdir() does not mention errors that can be raised

2019-07-06 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 1dd65075955337183ba2f78cb11a1eec2466dc74 by Terry Jan Reedy (Miss Islington (bot)) in branch '3.7': bpo-37478: Specify possible exceptions for os.chdir() (GH-14611) (GH-14630)

[issue37478] Docs: Method os.chdir() does not mention errors that can be raised

2019-07-06 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 4e6bfc4c605d92d2395fbcded9cf45cdd1ced810 by Terry Jan Reedy (Miss Islington (bot)) in branch '3.8': bpo-37478: Specify possible exceptions for os.chdir() (GH-14611) (GH-14629)

[issue37478] Docs: Method os.chdir() does not mention errors that can be raised

2019-07-06 Thread miss-islington
Change by miss-islington : -- pull_requests: +14443 stage: commit review -> patch review pull_request: https://github.com/python/cpython/pull/14629 ___ Python tracker ___

[issue37478] Docs: Method os.chdir() does not mention errors that can be raised

2019-07-06 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 0717b4d9b3899c5c2ca13031e4ff619a15a4d368 by Terry Jan Reedy (Kyle Stanley) in branch 'master': bpo-37478: Specify possible exceptions for os.chdir() (GH-14611) https://github.com/python/cpython/commit/0717b4d9b3899c5c2ca13031e4ff619a15a4d368

[issue37478] Docs: Method os.chdir() does not mention errors that can be raised

2019-07-06 Thread miss-islington
Change by miss-islington : -- pull_requests: +1 pull_request: https://github.com/python/cpython/pull/14630 ___ Python tracker ___

[issue37478] Docs: Method os.chdir() does not mention errors that can be raised

2019-07-06 Thread Terry J. Reedy
Terry J. Reedy added the comment: Please ask your questions about doc conventions, both about exceptions and function/method. Either someone will point to something in the devguide, or we might get a discussion about something that should be added. I would not merge more extensive changes

[issue37478] Docs: Method os.chdir() does not mention errors that can be raised

2019-07-05 Thread Kyle Stanley
Kyle Stanley added the comment: Actually, I don't believe that I have the appropriate permissions to manually specify reviewers for PRs in the cpython repository. Do I have to be added a member of the Python organization on GitHub for this? I'm registered as a PSF contributing member, but I

[issue37478] Docs: Method os.chdir() does not mention errors that can be raised

2019-07-05 Thread Kyle Stanley
Change by Kyle Stanley : -- keywords: +patch pull_requests: +14425 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14611 ___ Python tracker ___

[issue37478] Docs: Method os.chdir() does not mention errors that can be raised

2019-07-05 Thread Kyle Stanley
Kyle Stanley added the comment: Thanks for the feedback terry. Do you think it would be helpful to work through some of the other commonly used functions in OS, adding condensed explanations of exceptions which can be raised? In general, it seems quite useful for users to be able to figure

[issue37478] Docs: Method os.chdir() does not mention errors that can be raised

2019-07-05 Thread Terry J. Reedy
Terry J. Reedy added the comment: > what exactly is the standard for mentioning errors My impression is that there is none, or that it is inconsistent, but that the trend is to say more. If you want to followup, check the documentation chapters of the devguide, and if there is nothing clear

[issue37478] Docs: Method os.chdir() does not mention errors that can be raised

2019-07-01 Thread Kyle Stanley
Kyle Stanley added the comment: Minor clarifications: This change is referring to the "Files and Directories" section of the "os.rst" page in "cpython/Doc/library/os.rst". Also, I realized that I forgot to add the colon before "exc" in a couple locations. This was just a typo when writing

[issue37478] Docs: Method os.chdir() does not mention errors that can be raised

2019-07-01 Thread Kyle Stanley
New submission from Kyle Stanley : In the section describing the functionality of os.chdir(), there is no mention of possible errors that can be raised. This differentiates significantly from the sections of other methods, such as os.is_dir(): "This method can raise :exc:`OSError`, such as