[issue3758] "make check" suggest a testing target under GNU coding standards

Changes by Éric Araujo : -- resolution: accepted -> fixed stage: -> committed/rejected ___ Python tracker ___ ___ Python-bugs-list mai

[issue3758] "make check" suggest a testing target under GNU coding standards

Brett Cannon <[EMAIL PROTECTED]> added the comment: 2.7 through r66819, 2.6 through r66820, and 3.0 through r66821. -- status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3758] "make check" suggest a testing target under GNU coding standards

Changes by Brett Cannon <[EMAIL PROTECTED]>: -- status: closed -> open ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list m

[issue3758] "make check" suggest a testing target under GNU coding standards

Ralph Corderoy <[EMAIL PROTECTED]> added the comment: The patchcheck target isn't in .PHONY at the end of the file. ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue3758] "make check" suggest a testing target under GNU coding standards

Brett Cannon <[EMAIL PROTECTED]> added the comment: On the trunk with r66237 and 3.0 with r66238. -- resolution: -> accepted status: open -> closed ___ Python tracker <[EMAIL PROTECTED]>

[issue3758] "make check" suggest a testing target under GNU coding standards

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Patch looks fine to me. -- keywords: -needs review ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3758] "make check" suggest a testing target under GNU coding standards

Brett Cannon <[EMAIL PROTECTED]> added the comment: The attached patch renames the target to patchcheck. -- keywords: +needs review, patch Added file: http://bugs.python.org/file11394/rename_check.diff ___ Python tracker <[EMAIL PROTECTED]>

[issue3758] "make check" suggest a testing target under GNU coding standards

Brett Cannon <[EMAIL PROTECTED]> added the comment: OK, I am going to go with ``make patchcheck`` since that is the script's name and the command does nothing but execute the script. I will wait until after rc1 to deal with this. ___ Python tracker <[EMAIL PR

[issue3758] "make check" suggest a testing target under GNU coding standards

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: That suggests that it only need to run by committers. I find it useful, just for the reindenting whenever I'm writing a patch. ___ Python tracker <[EMAIL PROTECTED]> __

[issue3758] "make check" suggest a testing target under GNU coding standards

Brett Cannon <[EMAIL PROTECTED]> added the comment: Or how about ``make precommit``? -- priority: -> low ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3758] "make check" suggest a testing target under GNU coding standards

Brett Cannon <[EMAIL PROTECTED]> added the comment: On Tue, Sep 2, 2008 at 7:17 AM, Benjamin Peterson <[EMAIL PROTECTED]> wrote: > > Benjamin Peterson <[EMAIL PROTECTED]> added the comment: > > Brett, how about "patchcheck"? > Maybe. I will see if any inspiration comes to me in the near future.

[issue3758] "make check" suggest a testing target under GNU coding standards

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Brett, how about "patchcheck"? -- assignee: -> brett.cannon nosy: +benjamin.peterson, brett.cannon ___ Python tracker <[EMAIL PROTECTED]>

[issue3758] "make check" suggest a testing target under GNU coding standards

New submission from Ralph Corderoy <[EMAIL PROTECTED]>: A new target, "check", has been added to Makefile for 2.6. It runs some tests on the source code that are intended to check there's nothing wrong before preparing a patch. http://svn.python.org/view/python/trunk/Makefile.pre.in?rev=61528&v