[issue37598] Don't use _ as a function name in logging documentation cookbook

2019-07-16 Thread Vinay Sajip
Change by Vinay Sajip : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bu

[issue37598] Don't use _ as a function name in logging documentation cookbook

2019-07-16 Thread Vinay Sajip
Vinay Sajip added the comment: > Since order of kwargs is guaranteed from Python 3.6 can this be removed? Well, the statement about order isn't inaccurate when talking about Python in general and the cookbook is a resource meant to be useful across multiple Python implementations and version

[issue37598] Don't use _ as a function name in logging documentation cookbook

2019-07-16 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Slightly unrelated to the issue but I noticed the below statement in the docs page couple of times. I think it's related to the order of kwargs when the statement was added in 3d9e972270270e1498712065a17ec3a589ae8986. Since order of kwargs is guara

[issue37598] Don't use _ as a function name in logging documentation cookbook

2019-07-15 Thread Vinay Sajip
Vinay Sajip added the comment: The comment at the end of the "_ = ..." line indicates clearly that it's optional to do that, and I assume that any reader will realise that they can use any suitable variable name rather than "_". There's no particular "recommendation" to use "_" and cookbook

[issue37598] Don't use _ as a function name in logging documentation cookbook

2019-07-15 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +vinay.sajip ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue37598] Don't use _ as a function name in logging documentation cookbook

2019-07-15 Thread Andrew Carter
New submission from Andrew Carter : Current docs link: https://docs.python.org/3/howto/logging-cookbook.html#implementing-structured-logging GitHub commit link: https://github.com/python/cpython/commit/4b88d6c6642450240a9dc22e6efbdc69baf890dd The suggestion is that for structured logging, a