[issue37631] EXTRA_CFLAGS get overrided by CFLAGS_NODIST

2019-10-03 Thread Brett Cannon
Change by Brett Cannon : -- nosy: -brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37631] EXTRA_CFLAGS get overrided by CFLAGS_NODIST

2019-10-02 Thread Charalampos Stratakis
Charalampos Stratakis added the comment: Also this is due to an expected behaviour from gcc. From the documentation: "If you use multiple -O options, with or without level numbers, the last such option is the one that is effective. " -- ___

[issue37631] EXTRA_CFLAGS get overrided by CFLAGS_NODIST

2019-10-02 Thread Charalampos Stratakis
Charalampos Stratakis added the comment: Dug a bit further here. The issue is that CFLAGS_NODIST will always come after normal CFLAGS (which are subsets of PY_CFLAGS and PY_CFLAGS_NODIST) [0][1]. The EXTRA_CFLAGS variable is appended at the end of PY_CFLAGS [2], hence as reported here,

[issue37631] EXTRA_CFLAGS get overrided by CFLAGS_NODIST

2019-07-30 Thread STINNER Victor
STINNER Victor added the comment: IMHO comments in Makefile.pre.in is a good start. -- ___ Python tracker ___ ___ Python-bugs-list

[issue37631] EXTRA_CFLAGS get overrided by CFLAGS_NODIST

2019-07-30 Thread Charalampos Stratakis
Charalampos Stratakis added the comment: I agree that documenting the flags is quite important, I've had a hard time trying to figure out how to implement the LDFLAGS_NODIST, and the change still broke macos builds (luckily it was fixed swiftly). Nevertheless, this is still a bug which

[issue37631] EXTRA_CFLAGS get overrided by CFLAGS_NODIST

2019-07-30 Thread STINNER Victor
STINNER Victor added the comment: Python has way too many variables to control compiler flags: --- # Compiler options OPT=@OPT@ BASECFLAGS= @BASECFLAGS@ BASECPPFLAGS= @BASECPPFLAGS@ CONFIGURE_CFLAGS= @CFLAGS@ # CFLAGS_NODIST is used for building the interpreter and

[issue37631] EXTRA_CFLAGS get overrided by CFLAGS_NODIST

2019-07-30 Thread Miro Hrončok
Change by Miro Hrončok : -- nosy: +hroncok ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37631] EXTRA_CFLAGS get overrided by CFLAGS_NODIST

2019-07-30 Thread Miro Hrončok
Change by Miro Hrončok : -- keywords: +patch pull_requests: +14781 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15020 ___ Python tracker ___

[issue37631] EXTRA_CFLAGS get overrided by CFLAGS_NODIST

2019-07-22 Thread Marcel Plch
Marcel Plch added the comment: I believe you mean this downstream issue: https://bugzilla.redhat.com/show_bug.cgi?id=1712977 That issue is but only a consequence of a bad flag handling. The bad flag handling affects not only test_gdb on that specific architecture, but the entire

[issue37631] EXTRA_CFLAGS get overrided by CFLAGS_NODIST

2019-07-19 Thread Charalampos Stratakis
Charalampos Stratakis added the comment: Could you provide more info, e.g. comparison between the proper and the erroneous output, as well as what it affects (test_gdb if I recall correctly)? -- nosy: +cstratak ___ Python tracker

[issue37631] EXTRA_CFLAGS get overrided by CFLAGS_NODIST

2019-07-19 Thread Marcel Plch
New submission from Marcel Plch : Problem: If you want to override CFLAGS by setting EXTRA_CFLAGS, they may have no effect if there are contrary flags in the CFLAGS_NODIST variable. How to reproduce: make CFLAGS_NODIST="-O2" EXTRA_CFLAGS="-Og" If you look at GCC arguments, there is -O2