[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Raymond Hettinger added the comment: New changeset d6fdfc82dd307161caae938b7a6c85215bc1 by Raymond Hettinger (Miss Islington (bot)) in branch '3.8': bpo-37798: Prevent undefined behavior in direct calls to the C helper function. (GH-16149) (GH-16160) https://github.com/python/cpython/com

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Change by miss-islington : -- pull_requests: +15770 pull_request: https://github.com/python/cpython/pull/16160 ___ Python tracker ___ __

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Raymond Hettinger added the comment: New changeset 6e27a0d77520bf2c4412e367496212510f81b983 by Raymond Hettinger in branch 'master': bpo-37798: Prevent undefined behavior in direct calls to the C helper function. (#16149) https://github.com/python/cpython/commit/6e27a0d77520bf2c4412e36749621

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Change by Raymond Hettinger : -- pull_requests: +15759 pull_request: https://github.com/python/cpython/pull/16149 ___ Python tracker ___ ___

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Tal Einat added the comment: New changeset 58067d2cf6e81187f9782aff03cc8bec3d878778 by Tal Einat (Miss Islington (bot)) in branch '3.8': bpo-37798: Fix _statistics module doc (GH-15546) https://github.com/python/cpython/commit/58067d2cf6e81187f9782aff03cc8bec3d878778 -- ___

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Change by miss-islington : -- pull_requests: +15326 pull_request: https://github.com/python/cpython/pull/15660 ___ Python tracker ___ __

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Tal Einat added the comment: New changeset 0cf832a9ef84be6e18aad02464814530d80b82b2 by Tal Einat (Dong-hee Na) in branch 'master': bpo-37798: Fix _statistics module doc (GH-15546) https://github.com/python/cpython/commit/0cf832a9ef84be6e18aad02464814530d80b82b2 -- nosy: +taleinat _

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Dong-hee Na added the comment: @rhettinger If you are okay, Can you review PR 15546, please? IMHO, this issue should be fixed ASAP... Thanks again -- ___ Python tracker ___ __

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Change by Dong-hee Na : -- pull_requests: +15223 pull_request: https://github.com/python/cpython/pull/15546 ___ Python tracker ___ _

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Raymond Hettinger added the comment: New changeset 56c4d2d057de0dcb968148fa1286e587e91f5c91 by Raymond Hettinger (Miss Islington (bot)) in branch '3.8': bpo-37798: Minor code formatting and comment clean-ups. (GH-15526) (GH-15527) https://github.com/python/cpython/commit/56c4d2d057de0dcb96814

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Change by miss-islington : -- pull_requests: +15209 pull_request: https://github.com/python/cpython/pull/15527 ___ Python tracker ___ __

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Raymond Hettinger added the comment: New changeset 6fee0f8ea72fa68155a32b33b6c0ed9e5a740e45 by Raymond Hettinger in branch 'master': bpo-37798: Minor code formatting and comment clean-ups. (GH-15526) https://github.com/python/cpython/commit/6fee0f8ea72fa68155a32b33b6c0ed9e5a740e45 -

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Change by Raymond Hettinger : -- pull_requests: +15208 pull_request: https://github.com/python/cpython/pull/15526 ___ Python tracker ___ ___

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Dong-hee Na added the comment: Thank you for the mentoring of this work. It was great experience for me! -- ___ Python tracker ___ ___

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Raymond Hettinger added the comment: New changeset d5a66bc56f68d0f7cc3470722a31d7f731754af6 by Raymond Hettinger (Miss Islington (bot)) in branch '3.8': bpo-37798: Test both Python and C versions in test_statistics.py (GH-15453) (GH-15467) https://github.com/python/cpython/commit/d5a66bc56f6

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Raymond Hettinger added the comment: Thank you again. This was nice work. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker _

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Change by Raymond Hettinger : -- assignee: -> rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Raymond Hettinger added the comment: New changeset 8ad22a42267d4ecb1c080d420933680cc126363e by Raymond Hettinger (Dong-hee Na) in branch 'master': bpo-37798: Test both Python and C versions in test_statistics.py (GH-15453) https://github.com/python/cpython/commit/8ad22a42267d4ecb1c080d4209336

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Change by miss-islington : -- pull_requests: +15159 pull_request: https://github.com/python/cpython/pull/15467 ___ Python tracker ___ __

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Change by Dong-hee Na : -- pull_requests: +15146 pull_request: https://github.com/python/cpython/pull/15453 ___ Python tracker ___ _

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Dong-hee Na added the comment: > There's one more step. Can you please amend to the tests to run both the > pure python and C versions. Sure, I will take look at it! -- ___ Python tracker _

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Change by Raymond Hettinger : -- versions: +Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Raymond Hettinger added the comment: Thanks for doing the work one this. Nice work :-) There's one more step. Can you please amend to the tests to run both the pure python and C versions. See Lib/test/test_heapq.py for an example of how to this. -- __

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Raymond Hettinger added the comment: New changeset 5779c536321e1405b4c17654a85b8f9221be765e by Raymond Hettinger (Miss Islington (bot)) in branch '3.8': bpo-37798: Add C fastpath for statistics.NormalDist.inv_cdf() (GH-15266) (GH-15441) https://github.com/python/cpython/commit/5779c536321e14

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Raymond Hettinger added the comment: New changeset 0a18ee4be7ba215f414bef04598e0849504f9f1e by Raymond Hettinger (Dong-hee Na) in branch 'master': bpo-37798: Add C fastpath for statistics.NormalDist.inv_cdf() (GH-15266) https://github.com/python/cpython/commit/0a18ee4be7ba215f414bef04598e0849

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Change by miss-islington : -- pull_requests: +15134 pull_request: https://github.com/python/cpython/pull/15441 ___ Python tracker ___ __

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Change by Dong-hee Na : -- keywords: +patch pull_requests: +14987 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15266 ___ Python tracker ___

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Raymond Hettinger added the comment: > Can I work on this issue? > It might be my first C module addition task for CPython. Yes. This issue would be a good place to start. -- ___ Python tracker _

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Dong-hee Na added the comment: @rhettinger Hi, Can I work on this issue? It might be my first C module addition task for CPython. -- nosy: +corona10 ___ Python tracker ___ __

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

New submission from Raymond Hettinger : Create new module: Modules/_statisticsmodule.c Add a function:_normal_dist_inv_cdf(p, mu, sigma) |-> x Mostly, it should be a cut-and-paste from the pure Python version, just add argument processing and semi-colons. Expect to measure a manyfold sp