[issue37828] Fix default mock_name in unittest.mock.assert_called error message

2019-09-17 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue37828] Fix default mock_name in unittest.mock.assert_called error message

2019-09-17 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I don't think 3.7 needs a backport of the fix. I am closing this as fixed since all PRs are merged. Please reopen if a backport is needed. Thanks @categulario. -- ___ Python tracker

[issue37828] Fix default mock_name in unittest.mock.assert_called error message

2019-09-17 Thread miss-islington
miss-islington added the comment: New changeset f668d2b775da4bcd07e142c4bc5ebd88165fadf4 by Miss Islington (bot) in branch '3.8': bpo-37828: Fix default mock_name in unittest.mock.assert_called error (GH-16166) https://github.com/python/cpython/commit/f668d2b775da4bcd07e142c4bc5ebd88165fadf4

[issue37828] Fix default mock_name in unittest.mock.assert_called error message

2019-09-17 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 5f5f11faf9de0d8dcbe1a8a4eb35d2a4232d6eaa by Pablo Galindo (Abraham Toriz Cruz) in branch 'master': bpo-37828: Fix default mock_name in unittest.mock.assert_called error (GH-16166) https://github.com/python/cpython/commit/5f5f11faf9de0d8dc

[issue37828] Fix default mock_name in unittest.mock.assert_called error message

2019-09-17 Thread miss-islington
Change by miss-islington : -- pull_requests: +15827 pull_request: https://github.com/python/cpython/pull/16229 ___ Python tracker ___ __

[issue37828] Fix default mock_name in unittest.mock.assert_called error message

2019-09-15 Thread Abraham
Change by Abraham : -- keywords: +patch pull_requests: +15775 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16166 ___ Python tracker ___

[issue37828] Fix default mock_name in unittest.mock.assert_called error message

2019-08-12 Thread Karthikeyan Singaravelan
New submission from Karthikeyan Singaravelan : In the format string for assert_called the evaluation order is incorrect and hence for mock's without name 'None' is printed whereas it should be 'mock' like for other messages. The error message is ("Expected '%s' to have been called." % self._m