[issue37872] Move statitics in Python/import.c to top of the file

2019-08-16 Thread Joannah Nanjekye
Joannah Nanjekye added the comment: Keeping this until the PR https://github.com/python/cpython/pull/15057 is merged. -- ___ Python tracker ___

[issue37872] Move statitics in Python/import.c to top of the file

2019-08-16 Thread Joannah Nanjekye
Joannah Nanjekye added the comment: Relevant comment from @gnprice. I think it would be better to make that as a separate change. This style where they're block-local is the way the existing code works, which keeps the diff simple. It's also the way that every use of _Py_IDENTIFIER in

[issue37872] Move statitics in Python/import.c to top of the file

2019-08-16 Thread Joannah Nanjekye
New submission from Joannah Nanjekye : Following a PR review here: https://github.com/python/cpython/pull/15057 by @ericsnowcurrently i.e : Please move both these statics to the top of the file (next to CACHEDIR) as globals. To keep the diff in the above PR simple, I am tracking this