[issue37945] [Windows] test_locale.TestMiscellaneous.test_getsetlocale_issue1813() fails

STINNER Victor added the comment: > Great! For the first time in over 2 years, the test suite passes on a > Windows repository build on my machine. Nice :-) -- ___ Python tracker

[issue37945] [Windows] test_locale.TestMiscellaneous.test_getsetlocale_issue1813() fails

Terry J. Reedy added the comment: Great! For the first time in over 2 years, the test suite passes on a Windows repository build on my machine. I will test installed 3.10 after the next alpha release. (3.10.0a7 has other failures as well.) --

[issue37945] [Windows] test_locale.TestMiscellaneous.test_getsetlocale_issue1813() fails

STINNER Victor added the comment: Ok, the initial issue has been fixed: test_locale pass again on Windows. Let's continue the discussion on getlocale() in bpo-43557 "Deprecate getdefaultlocale(), getlocale() and normalize() functions" ;-) -- priority: release blocker -> resolution:

[issue37945] [Windows] test_locale.TestMiscellaneous.test_getsetlocale_issue1813() fails

Łukasz Langa added the comment: New changeset e143eea4b56ac7ae611e5bcc41eedbc572aa41c3 by Miss Islington (bot) in branch '3.8': bpo-37945: Fix test_locale.test_getsetlocale_issue1813() (GH-25110) (GH-25113) https://github.com/python/cpython/commit/e143eea4b56ac7ae611e5bcc41eedbc572aa41c3

[issue37945] [Windows] test_locale.TestMiscellaneous.test_getsetlocale_issue1813() fails

Łukasz Langa added the comment: New changeset fabdd25fe505c08da064425ea4d099fd2cef39d3 by Miss Islington (bot) in branch '3.9': bpo-37945: Fix test_locale.test_getsetlocale_issue1813() (GH-25110) (GH-25112) https://github.com/python/cpython/commit/fabdd25fe505c08da064425ea4d099fd2cef39d3

[issue37945] [Windows] test_locale.TestMiscellaneous.test_getsetlocale_issue1813() fails

Change by miss-islington : -- pull_requests: +23857 pull_request: https://github.com/python/cpython/pull/25113 ___ Python tracker ___

[issue37945] [Windows] test_locale.TestMiscellaneous.test_getsetlocale_issue1813() fails

Łukasz Langa added the comment: New changeset f3ab670fea75ebe177e3412a5ebe39263cd428e3 by Victor Stinner in branch 'master': bpo-37945: Fix test_locale.test_getsetlocale_issue1813() (#25110) https://github.com/python/cpython/commit/f3ab670fea75ebe177e3412a5ebe39263cd428e3 --

[issue37945] [Windows] test_locale.TestMiscellaneous.test_getsetlocale_issue1813() fails

Change by miss-islington : -- nosy: +miss-islington nosy_count: 15.0 -> 16.0 pull_requests: +23856 pull_request: https://github.com/python/cpython/pull/25112 ___ Python tracker

[issue37945] [Windows] test_locale.TestMiscellaneous.test_getsetlocale_issue1813() fails

Łukasz Langa added the comment: Oh, Victor's solution is fine as well. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue37945] [Windows] test_locale.TestMiscellaneous.test_getsetlocale_issue1813() fails

Łukasz Langa added the comment: Yeah, I'm making the change David suggested. It applies to 3.8 as well. -- versions: +Python 3.8 ___ Python tracker ___

[issue37945] [Windows] test_locale.TestMiscellaneous.test_getsetlocale_issue1813() fails

STINNER Victor added the comment: I wrote PR 25110 to simply skip the test if setlocale() fails. It fix the issue on Windows (I tested manually, see my comment on my PR), but it should also fix the issue on OpenBSD and any platform where getlocale() returns a locale not accepted by

[issue37945] [Windows] test_locale.TestMiscellaneous.test_getsetlocale_issue1813() fails

Change by STINNER Victor : -- pull_requests: -23809 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37945] [Windows] test_locale.TestMiscellaneous.test_getsetlocale_issue1813() fails

Change by STINNER Victor : -- pull_requests: +23854 pull_request: https://github.com/python/cpython/pull/25110 ___ Python tracker ___

[issue37945] [Windows] test_locale.TestMiscellaneous.test_getsetlocale_issue1813() fails

STINNER Victor added the comment: On Windows 10 build 1903, vstinner@WIN C:\vstinner\python\master>python -m test test_locale -m test_getsetlocale_issue1813 -v == CPython 3.10.0a6+ (heads/master:ff3c9739bd, Mar 31 2021, 12:43:26) [MSC v.1916 64 bit (AMD64)] == Windows-10-10.0.18362-SP0

[issue37945] [Windows] test_locale.TestMiscellaneous.test_getsetlocale_issue1813() fails

David Bolen added the comment: In lieu of the patch in #25191, what about a pair of skips to deal with the issues at hand without killing the test entirely? I'm including OpenBSD since those issues were closed in favor of this one, and am assuming that skipping there is also appropriate.

[issue37945] [Windows] test_locale.TestMiscellaneous.test_getsetlocale_issue1813() fails

Steve Dower added the comment: This is now holding up some security releases (due to a couple of CVEs). Can we get the test skipped or fixed asap, please? -- nosy: +lukasz.langa, ned.deily priority: normal -> release blocker ___ Python tracker

[issue37945] [Windows] test_locale.TestMiscellaneous.test_getsetlocale_issue1813() fails

Change by Doug Richardson : -- nosy: -drichardson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37945] [Windows] test_locale.TestMiscellaneous.test_getsetlocale_issue1813() fails

David Bolen added the comment: I don't have much of a horse in the race, but since the test has historically been skipped on Windows, and the test hasn't and doesn't work on Windows, modifications to restore the skip behavior seem reasonable to me. The trigger for this issue was Windows

[issue37945] [Windows] test_locale.TestMiscellaneous.test_getsetlocale_issue1813() fails

Terry J. Reedy added the comment: So, can we delete it? PR 19781 is for #43510 and is listed here above only because this issue is mentioned. -- ___ Python tracker ___

[issue37945] [Windows] test_locale.TestMiscellaneous.test_getsetlocale_issue1813() fails

Change by Inada Naoki : -- keywords: +patch nosy: +methane nosy_count: 13.0 -> 14.0 pull_requests: +23809 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/19481 ___ Python tracker

[issue37945] [Windows] test_locale.TestMiscellaneous.test_getsetlocale_issue1813() fails

Change by Jeremy Kloth : -- nosy: +jkloth ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37945] [Windows] test_locale.TestMiscellaneous.test_getsetlocale_issue1813() fails

David Bolen added the comment: The test has also begun failing on the Win10 buildbot (after updating to 20H2 from an older 1803). -- nosy: +db3l ___ Python tracker ___

[issue37945] [Windows] test_locale.TestMiscellaneous.test_getsetlocale_issue1813() fails

STINNER Victor added the comment: "ERROR: test_getsetlocale_issue1813 (test.test_locale.TestMiscellaneous)" fails on the Windows x64 job of GitHub Actions when Python is built in debug mode: https://github.com/python/cpython/pull/24914 -- nosy: +vstinner

[issue37945] [Windows] test_locale.TestMiscellaneous.test_getsetlocale_issue1813() fails

Change by STINNER Victor : -- nosy: -vstinner title: test_locale.TestMiscellaneous.test_getsetlocale_issue1813() fails -> [Windows] test_locale.TestMiscellaneous.test_getsetlocale_issue1813() fails ___ Python tracker