[issue38005] Coercing strings and non-integer numbers to interpreter ID and channel ID

miss-islington added the comment: New changeset ca14f047b068cd0fb81ef3d5e7bea19fe8af1b58 by Miss Islington (bot) in branch '3.8': bpo-38005: Remove support of string argument in InterpreterID(). (GH-16227) https://github.com/python/cpython/commit/ca14f047b068cd0fb81ef3d5e7bea19fe8af1b58 ---

[issue38005] Coercing strings and non-integer numbers to interpreter ID and channel ID

Change by miss-islington : -- pull_requests: +15976 pull_request: https://github.com/python/cpython/pull/16394 ___ Python tracker ___ __

[issue38005] Coercing strings and non-integer numbers to interpreter ID and channel ID

Serhiy Storchaka added the comment: New changeset 543a3951a1c96bae0ea839eacec71d3b1a563a10 by Serhiy Storchaka in branch 'master': bpo-38005: Remove support of string argument in InterpreterID(). (GH-16227) https://github.com/python/cpython/commit/543a3951a1c96bae0ea839eacec71d3b1a563a10 --

[issue38005] Coercing strings and non-integer numbers to interpreter ID and channel ID

Change by Serhiy Storchaka : -- pull_requests: +15825 pull_request: https://github.com/python/cpython/pull/16227 ___ Python tracker ___

[issue38005] Coercing strings and non-integer numbers to interpreter ID and channel ID

Eric Snow added the comment: Yeah, dropping str support is fine. It wouldn't be hard to add it back in if later we find it's useful. :) -- ___ Python tracker ___ ___

[issue38005] Coercing strings and non-integer numbers to interpreter ID and channel ID

Serhiy Storchaka added the comment: I would remove also converting a string to InterpreterID. The code would be simpler without it. I left it because there was explicit tests for it, but what is a use case for InterpreterID(string)? -- resolution: -> fixed stage: patch review -> res

[issue38005] Coercing strings and non-integer numbers to interpreter ID and channel ID

Serhiy Storchaka added the comment: New changeset f37a9831027ecfe948697cdb5e35b417805d94e5 by Serhiy Storchaka in branch '3.8': [3.8] bpo-38005: Fixed comparing and creating of InterpreterID and ChannelID. (GH-15652) (GH-16145) https://github.com/python/cpython/commit/f37a9831027ecfe948697cd

[issue38005] Coercing strings and non-integer numbers to interpreter ID and channel ID

Change by Serhiy Storchaka : -- pull_requests: +15755 pull_request: https://github.com/python/cpython/pull/16145 ___ Python tracker ___

[issue38005] Coercing strings and non-integer numbers to interpreter ID and channel ID

Change by miss-islington : -- pull_requests: +15740 pull_request: https://github.com/python/cpython/pull/16129 ___ Python tracker ___ __

[issue38005] Coercing strings and non-integer numbers to interpreter ID and channel ID

Serhiy Storchaka added the comment: New changeset bf169915ecdd42329726104278eb723a7dda2736 by Serhiy Storchaka in branch 'master': bpo-38005: Fixed comparing and creating of InterpreterID and ChannelID. (GH-15652) https://github.com/python/cpython/commit/bf169915ecdd42329726104278eb723a7dda2

[issue38005] Coercing strings and non-integer numbers to interpreter ID and channel ID

Change by Serhiy Storchaka : -- type: behavior -> crash ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue38005] Coercing strings and non-integer numbers to interpreter ID and channel ID

Serhiy Storchaka added the comment: There is more serious issue: InterpreterID and ChannelID are declared as int subclasses, but actually they have incompatible structure, so using them as int causes a crash. For example, the following code is crashed: float(int(id)) == id -- _

[issue38005] Coercing strings and non-integer numbers to interpreter ID and channel ID

Serhiy Storchaka added the comment: I have doubts about accepting floats and bytes objects in all function that accept InterpreterID or ChannelID. Is it intentional? There are tests for strings. -- ___ Python tracker

[issue38005] Coercing strings and non-integer numbers to interpreter ID and channel ID

Terry J. Reedy added the comment: Regardless of the intention of the _xx... author, intransitive equality is objectionable as it violates the assumption of sets and dicts. We went through this before with decimal.Decimal when the original implementation had 1.0 == 1 == Decimal(1) but 1.0 !=

[issue38005] Coercing strings and non-integer numbers to interpreter ID and channel ID

Change by Serhiy Storchaka : -- components: +Interpreter Core type: -> behavior versions: +Python 3.8, Python 3.9 ___ Python tracker ___ __

[issue38005] Coercing strings and non-integer numbers to interpreter ID and channel ID

Serhiy Storchaka added the comment: PR 15652 fixes some bugs. But I am not sure that floats and strings (and bytearrays, and fractions) should be accepted in constructors and several other functions. Although there was a test for strings. What is a use case? Should not an ID be an integer?

[issue38005] Coercing strings and non-integer numbers to interpreter ID and channel ID

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +15319 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15652 ___ Python tracker ___

[issue38005] Coercing strings and non-integer numbers to interpreter ID and channel ID

Change by Serhiy Storchaka : -- title: Coercing strings and non-integer numbers to interpreter ID -> Coercing strings and non-integer numbers to interpreter ID and channel ID ___ Python tracker _