[issue3805] sslobj.read py3k takes odd arguments

Antoine Pitrou pit...@free.fr added the comment: Cleanup done in r84464 (py3k), r84465 (3.1). -- resolution: - fixed stage: - committed/rejected status: open - closed versions: +Python 3.1, Python 3.2 -Python 3.0 ___ Python tracker

[issue3805] sslobj.read py3k takes odd arguments

Changes by Georg Brandl ge...@python.org: -- assignee: janssen - pitrou nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3805 ___ ___

[issue3805] sslobj.read py3k takes odd arguments

Bill Janssen [EMAIL PROTECTED] added the comment: Please, guys, let's not deep-end on this. It's an admittedly eccentric but working and purely internal interface. There are actual release-blockers that need to be addressed. On Tue, Sep 9, 2008 at 4:14 AM, Amaury Forgeot d'Arc [EMAIL

[issue3805] sslobj.read py3k takes odd arguments

Changes by Bill Janssen [EMAIL PROTECTED]: Removed file: http://bugs.python.org/file11446/unnamed ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3805 ___ ___

[issue3805] sslobj.read py3k takes odd arguments

Bill Janssen [EMAIL PROTECTED] added the comment: But I should say... Greg, I do appreciate the review and the comments. I was waiting for the bytes work in 3K to settle down before looking at that code again. When I do, I'll take your comments to heart.

[issue3805] sslobj.read py3k takes odd arguments

Gregory P. Smith [EMAIL PROTECTED] added the comment: yep, agreed. leave this for later. my bad for opening it with high priority in the first place. low is correct. :) i was just trying to write down comments on odd code that i came across before i forgot about it.

[issue3805] sslobj.read py3k takes odd arguments

New submission from Gregory P. Smith [EMAIL PROTECTED]: Modules/_ssl.c in the py3k branch: PySSL_SSLread(): calls parsetuple expecting |Oi as arguments. However the logic below to interpret and use the arguments is very convoluted. it'd be better to reorder these as |iO to match the api in

[issue3805] sslobj.read py3k takes odd arguments

Bill Janssen [EMAIL PROTECTED] added the comment: There was a reason to do it that way. Now if I can only remember what it was... ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3805 ___

[issue3805] sslobj.read py3k takes odd arguments

Changes by Bill Janssen [EMAIL PROTECTED]: -- priority: high - low ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3805 ___ ___ Python-bugs-list mailing

[issue3805] sslobj.read py3k takes odd arguments

Gregory P. Smith [EMAIL PROTECTED] added the comment: i only had a brief look when i was going through code looking for potentially incorrect uses of PyByteArray_*. I've got a patch that i believe cleans it up a little but its sitting on a machine i don't have remote access to at the moment.