[issue38248] inconsistency in asyncio.Task between cancellation while running vs. cancellation immediately after it finishes

2019-10-01 Thread Yury Selivanov
Change by Yury Selivanov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue38248] inconsistency in asyncio.Task between cancellation while running vs. cancellation immediately after it finishes

2019-10-01 Thread STINNER Victor
STINNER Victor added the comment: Can this issue be closed now? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue38248] inconsistency in asyncio.Task between cancellation while running vs. cancellation immediately after it finishes

2019-10-01 Thread STINNER Victor
STINNER Victor added the comment: New changeset bfe1f74e39d0049a829962050e86a6a2d2a2781e by Victor Stinner in branch '3.8': [3.8] bpo-3832: Fix compiler warnings (GH-16518) https://github.com/python/cpython/commit/bfe1f74e39d0049a829962050e86a6a2d2a2781e --

[issue38248] inconsistency in asyncio.Task between cancellation while running vs. cancellation immediately after it finishes

2019-09-30 Thread STINNER Victor
STINNER Victor added the comment: New changeset efe74b6369a8d08f27c69703fcc1686966e51068 by Victor Stinner in branch 'master': bpo-38321: Fix _asynciomodule.c compiler warning (GH-16493) https://github.com/python/cpython/commit/efe74b6369a8d08f27c69703fcc1686966e51068 -- nosy: +vsti

[issue38248] inconsistency in asyncio.Task between cancellation while running vs. cancellation immediately after it finishes

2019-09-30 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +16081 pull_request: https://github.com/python/cpython/pull/16493 ___ Python tracker ___ __

[issue38248] inconsistency in asyncio.Task between cancellation while running vs. cancellation immediately after it finishes

2019-09-25 Thread Carol Willing
Carol Willing added the comment: New changeset 16cec136b75daf438080a5b6685d2679dfa406af by Carol Willing (Miss Islington (bot)) in branch '3.8': bpo-38248: Fix inconsistent immediate asyncio.Task cancellation (GH-16330) (GH-16383) https://github.com/python/cpython/commit/16cec136b75daf438080

[issue38248] inconsistency in asyncio.Task between cancellation while running vs. cancellation immediately after it finishes

2019-09-25 Thread miss-islington
Change by miss-islington : -- pull_requests: +15963 pull_request: https://github.com/python/cpython/pull/16383 ___ Python tracker ___ __

[issue38248] inconsistency in asyncio.Task between cancellation while running vs. cancellation immediately after it finishes

2019-09-25 Thread miss-islington
Change by miss-islington : -- pull_requests: +15963, 15964, 15965 pull_request: https://github.com/python/cpython/pull/16383 ___ Python tracker ___

[issue38248] inconsistency in asyncio.Task between cancellation while running vs. cancellation immediately after it finishes

2019-09-25 Thread miss-islington
Change by miss-islington : -- pull_requests: +15963, 15964 pull_request: https://github.com/python/cpython/pull/16383 ___ Python tracker ___ ___

[issue38248] inconsistency in asyncio.Task between cancellation while running vs. cancellation immediately after it finishes

2019-09-25 Thread Carol Willing
Carol Willing added the comment: New changeset edad4d89e357c92f70c0324b937845d652b20afd by Carol Willing (Yury Selivanov) in branch 'master': bpo-38248: Fix inconsistent immediate asyncio.Task cancellation (GH-16330) https://github.com/python/cpython/commit/edad4d89e357c92f70c0324b937845d652b

[issue38248] inconsistency in asyncio.Task between cancellation while running vs. cancellation immediately after it finishes

2019-09-22 Thread Yury Selivanov
Change by Yury Selivanov : -- keywords: +patch pull_requests: +15907 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16330 ___ Python tracker ___ _

[issue38248] inconsistency in asyncio.Task between cancellation while running vs. cancellation immediately after it finishes

2019-09-22 Thread Yury Selivanov
Yury Selivanov added the comment: > The obvious fix would be to modify the 'except StopIteration' branch to > handle this case by calling super().cancel() instead of > super().set_exception(...). Yeah, I think this is the solution we should do in 3.8. -- ___

[issue38248] inconsistency in asyncio.Task between cancellation while running vs. cancellation immediately after it finishes

2019-09-22 Thread Nathaniel Smith
New submission from Nathaniel Smith : Just noticed this while looking at the code to asyncio.Task.__step asyncio Futures have two different error states: they can have an arbitrary exception set, or they can be marked as cancelled. asyncio Tasks handle this by detecting what exception was rai