[issue38281] "+" ignored when determining file mode in gzip.GzipFile.__init__

2019-09-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Yes, this is a breaking change, it will break the code that reads gzipped temporary files. Note also that even if this change be accepted, you could not use this feature until Python 3.9 be released. But you can write to temporary files in all Python vers

[issue38281] "+" ignored when determining file mode in gzip.GzipFile.__init__

2019-09-25 Thread Roundup Robot
Change by Roundup Robot : -- keywords: +patch pull_requests: +15986 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16405 ___ Python tracker ___ __

[issue38281] "+" ignored when determining file mode in gzip.GzipFile.__init__

2019-09-25 Thread __starrify__
New submission from __starrify__ : Currently (as of df69e75) it checks only the initial letter (via `mode.startswith`) of "mode" in gzip.GzipFile.__init__. See also: https://github.com/python/cpython/blob/df69e75/Lib/gzip.py#L183 I'd personally suggest that it takes also "+" into consideratio