[issue38335] simplify overlaps function in ipaddress.py

Sanjay added the comment: the version in the patch is less code a or b or c or d becomes a or d the version in PR is using the subnet_of, supernet_of function because overlap means either a is subnet_of or supernet_of b. So was trying to consolidate the implementation of overlap from 2 to

[issue38335] simplify overlaps function in ipaddress.py

Serhiy Storchaka added the comment: What is the benefit of your version? -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue38335] simplify overlaps function in ipaddress.py

Change by Sanjay : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38335] simplify overlaps function in ipaddress.py

Change by Sanjay : -- pull_requests: +16110 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16519 ___ Python tracker ___

[issue38335] simplify overlaps function in ipaddress.py

New submission from Sanjay : the current implementation of overlaps function tests either network or broadcast address is in other but we can skip checking broadcast address is in other because we anyway check if other.network_address in self without loss of generality if we assume self has