[issue38344] activate.bat else needs to be on the same line as the if

Ned Deily added the comment: (3.7.5 is released with this fix) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue38344] activate.bat else needs to be on the same line as the if

Ned Deily added the comment: New changeset ab22c8bc488e822d03c4778b30ec60131ea35c63 by Ned Deily (Miss Islington (bot)) in branch '3.7': bpo-38344: Fix syntax in activate.bat (GH-16533) https://github.com/python/cpython/commit/ab22c8bc488e822d03c4778b30ec60131ea35c63 -- ___

[issue38344] activate.bat else needs to be on the same line as the if

Łukasz Langa added the comment: (3.8.0 is released with this fix) -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___ __

[issue38344] activate.bat else needs to be on the same line as the if

Change by Kyle Stanley : -- stage: patch review -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue38344] activate.bat else needs to be on the same line as the if

miss-islington added the comment: New changeset 4880e5a1b66d9175fcc402cb0288bc1898356831 by Miss Islington (bot) in branch '3.8': bpo-38344: Fix syntax in activate.bat (GH-16533) https://github.com/python/cpython/commit/4880e5a1b66d9175fcc402cb0288bc1898356831 -- __

[issue38344] activate.bat else needs to be on the same line as the if

miss-islington added the comment: New changeset bfb5f9a66cc348c9cf25c857ad9910479e587517 by Miss Islington (bot) in branch '3.7': bpo-38344: Fix syntax in activate.bat (GH-16533) https://github.com/python/cpython/commit/bfb5f9a66cc348c9cf25c857ad9910479e587517 -- nosy: +miss-islingt

[issue38344] activate.bat else needs to be on the same line as the if

Steve Dower added the comment: I've merged the fix so that it can be cherry-picked for the upcoming releases. I'd still like to see the tests enhanced to be able to detect error output in the scripts, but those don't need to necessarily make it into the upcoming releases. -- __

[issue38344] activate.bat else needs to be on the same line as the if

Change by miss-islington : -- pull_requests: +16214 pull_request: https://github.com/python/cpython/pull/16628 ___ Python tracker ___ __

[issue38344] activate.bat else needs to be on the same line as the if

Change by miss-islington : -- pull_requests: +16213 pull_request: https://github.com/python/cpython/pull/16627 ___ Python tracker ___ __

[issue38344] activate.bat else needs to be on the same line as the if

Steve Dower added the comment: New changeset e310af9e2941c2fbb7370e003276cc37eb230f16 by Steve Dower (James Abel) in branch 'master': bpo-38344: Fix syntax in activate.bat (GH-16533) https://github.com/python/cpython/commit/e310af9e2941c2fbb7370e003276cc37eb230f16 -- __

[issue38344] activate.bat else needs to be on the same line as the if

Steve Dower added the comment: Also adding Ned - this made it into 3.7 as well. -- nosy: +ned.deily versions: +Python 3.7 ___ Python tracker ___ __

[issue38344] activate.bat else needs to be on the same line as the if

Steve Dower added the comment: Adding this to the end of test_unicode_in_batch_file seems to be sufficient to cause the test to fail: self.assertEqual(err.strip(), '') Potentially we should add that additional check throughout this test module, but I don't think that's needed for a

[issue38344] activate.bat else needs to be on the same line as the if

Steve Dower added the comment: Should be a straightforward fix (replace the "else" with "if not defined..."), but since it slipped through testing we probably want a regression test in test_venv as well. (+RM for the 3.8 regression) -- keywords: +3.8regression nosy: +lukasz.langa pr

[issue38344] activate.bat else needs to be on the same line as the if

Change by James Abel : -- keywords: +patch pull_requests: +16122 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16533 ___ Python tracker ___ _

[issue38344] activate.bat else needs to be on the same line as the if

New submission from James Abel : In activate.bat, the else needs to be on the same line as the if -- components: Windows messages: 353722 nosy: James Abel, paul.moore, steve.dower, tim.golden, zach.ware priority: normal severity: normal status: open title: activate.bat else needs to be