[issue38431] dataclasses.InitVar breaks with typing.Optional

Serhiy Storchaka added the comment: Thank you for your contribution Samuel! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue38431] dataclasses.InitVar breaks with typing.Optional

miss-islington added the comment: New changeset 6da52ac411947d1a7958bbad831fcf8dfc8c95fe by Miss Islington (bot) in branch '3.8': bpo-38431: Fix __repr__ method of InitVar to work with typing objects. (GH-16702) https://github.com/python/cpython/commit/6da52ac411947d1a7958bbad831fcf8dfc8c95f

[issue38431] dataclasses.InitVar breaks with typing.Optional

Change by miss-islington : -- pull_requests: +16321 pull_request: https://github.com/python/cpython/pull/16744 ___ Python tracker ___ __

[issue38431] dataclasses.InitVar breaks with typing.Optional

Serhiy Storchaka added the comment: New changeset 793cb85437299a3da3d74fe65480d720af330cbb by Serhiy Storchaka (Samuel Colvin) in branch 'master': bpo-38431: Fix __repr__ method of InitVar to work with typing objects. (GH-16702) https://github.com/python/cpython/commit/793cb85437299a3da3d74f

[issue38431] dataclasses.InitVar breaks with typing.Optional

Change by Ivan Levkivskyi : -- nosy: +levkivskyi ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue38431] dataclasses.InitVar breaks with typing.Optional

Change by Samuel Colvin : -- pull_requests: +16288 pull_request: https://github.com/python/cpython/pull/16702 ___ Python tracker ___ ___

[issue38431] dataclasses.InitVar breaks with typing.Optional

Serhiy Storchaka added the comment: Oh, Samuel already made a PR. Then I withdraw PR 16701. -- nosy: +serhiy.storchaka ___ Python tracker ___ _

[issue38431] dataclasses.InitVar breaks with typing.Optional

Change by Serhiy Storchaka : -- pull_requests: +16287 pull_request: https://github.com/python/cpython/pull/16701 ___ Python tracker ___

[issue38431] dataclasses.InitVar breaks with typing.Optional

Change by Samuel Colvin : -- keywords: +patch pull_requests: +16286 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16700 ___ Python tracker ___ __

[issue38431] dataclasses.InitVar breaks with typing.Optional

Karthikeyan Singaravelan added the comment: git blame points to https://github.com/python/cpython/commit/01ee12ba35a333e8a6a25c4153c4a21838e9585c . I am tagging this as a 3.8 regression since the commit was not backported and 3.7 works fine. Feel free to remove it if it's a mistake. ---

[issue38431] dataclasses.InitVar breaks with typing.Optional

Samuel Colvin added the comment: This is a bug with the `__repr__` method on `InitVar`. I'm working on a PR now. -- ___ Python tracker ___ ___

[issue38431] dataclasses.InitVar breaks with typing.Optional

Change by Karthikeyan Singaravelan : -- nosy: +eric.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue38431] dataclasses.InitVar breaks with typing.Optional

New submission from Samuel Colvin : The following code works fine with python 3.7 but breaks with 3.8: ``` import dataclasses from typing import Optional @dataclasses.dataclass class TestingDataclass: base_path: dataclasses.InitVar[Optional[str]] = None ``` Exception traceback: ``` Trace