[issue38467] Misspelled argument names for typing.get_origin and get_args

2019-10-13 Thread Ivan Levkivskyi
Change by Ivan Levkivskyi : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue38467] Misspelled argument names for typing.get_origin and get_args

2019-10-13 Thread miss-islington
miss-islington added the comment: New changeset c732660b7b18352ba8524ac78d39975afe4392ef by Miss Islington (bot) in branch '3.8': bpo-38467: Fix argument name of typing functions (GH-16753) https://github.com/python/cpython/commit/c732660b7b18352ba8524ac78d39975afe4392ef -- nosy:

[issue38467] Misspelled argument names for typing.get_origin and get_args

2019-10-13 Thread Ivan Levkivskyi
Ivan Levkivskyi added the comment: New changeset fdfe2833ace93021278fe4c41c40e1d08d70abf9 by Ivan Levkivskyi (Sebastian Rittau) in branch 'master': bpo-38467: Fix argument name of typing functions (GH-16753) https://github.com/python/cpython/commit/fdfe2833ace93021278fe4c41c40e1d08d70abf9

[issue38467] Misspelled argument names for typing.get_origin and get_args

2019-10-13 Thread miss-islington
Change by miss-islington : -- pull_requests: +16327 pull_request: https://github.com/python/cpython/pull/16754 ___ Python tracker ___

[issue38467] Misspelled argument names for typing.get_origin and get_args

2019-10-13 Thread Sebastian Rittau
Sebastian Rittau added the comment: https://github.com/python/cpython/pull/16753 -- ___ Python tracker ___ ___ Python-bugs-list

[issue38467] Misspelled argument names for typing.get_origin and get_args

2019-10-13 Thread Sebastian Rittau
Change by Sebastian Rittau : -- keywords: +patch pull_requests: +16326 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16753 ___ Python tracker

[issue38467] Misspelled argument names for typing.get_origin and get_args

2019-10-13 Thread Ivan Levkivskyi
Ivan Levkivskyi added the comment: I think adjusting the docs would be less disruptive than changing implementation. Would you like to make a PR? -- ___ Python tracker ___

[issue38467] Misspelled argument names for typing.get_origin and get_args

2019-10-13 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +levkivskyi ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38467] Misspelled argument names for typing.get_origin and get_args

2019-10-13 Thread Sebastian Rittau
New submission from Sebastian Rittau : The arguments for typing.get_origin() and typing.get_args() are named "typ" in the documentation (https://docs.python.org/3.8/library/typing.html#typing.get_origin), while they are named "tp" in the implementation. Important if used as keyword argument.